Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement bounded least_squares #25

Open
Dan-Burns opened this issue Mar 23, 2023 · 3 comments
Open

implement bounded least_squares #25

Dan-Burns opened this issue Mar 23, 2023 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Dan-Burns
Copy link

Hello,

I'm trying to use least_squares and got the following error.

NotImplementedError Traceback (most recent call last)
in
----> 1 jac0=least_squares(chi2,
2 par_theta,
3 bounds=bounds,
4 ftol=10^-5,xtol=10^-7)
5 par=jac0.x

1 frames
/usr/local/lib/python3.9/site-packages/torchmin/lstsq/trf.py in trf(fun, x0, f0, lb, ub, ftol, xtol, gtol, max_nfev, x_scale, tr_solver, tr_options, verbose)
27 tr_solver, tr_options, verbose)
28 else:
---> 29 raise NotImplementedError('trf with bounds not currently supported.')
30
31

NotImplementedError: trf with bounds not currently supported.

@rfeinman
Copy link
Owner

Hi @Dan-Burns - bounded least squares is not yet implemented. I have my hands full at the moment but if you'd like to contribute an implementation I'd be happy to review a PR.

@rfeinman rfeinman changed the title least_squares "trf with bounds not currently supported." implement bounded least_squares Mar 23, 2023
@rfeinman rfeinman added enhancement New feature or request help wanted Extra attention is needed labels Mar 23, 2023
@JordinaAviles
Copy link

Hi, I was wondering if the bounded least squares is already available or work is still going on. Thanks!

@rfeinman
Copy link
Owner

@JordinaAviles unfortunately I have not had time to implement this, but I'd be open to a PR if you'd like to contribute. Help is much needed and greatly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants