Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

❔ Supporting images for a private repository #28

Open
ollyhensby opened this issue May 8, 2024 · 2 comments
Open

❔ Supporting images for a private repository #28

ollyhensby opened this issue May 8, 2024 · 2 comments

Comments

@ollyhensby
Copy link

Question
I have a private repository that belongs to the organisation that I work for and it isn't possible to make it public.

Is there any way to support images that are used in the release notes?

The output currently doesn't show the image that exists in the release notes:

image

I assume this is because the documentation cannot access the image asset due to it being private.

Any help with this is much appreciated!

@rhysd
Copy link
Owner

rhysd commented May 9, 2024

Do you upload the image to the release note directly on GitHub? If so, that looks a limitation of GitHub that an image uploaded to a release page is not made public outside the page.

@ollyhensby
Copy link
Author

ollyhensby commented May 23, 2024

Hi @rhysd, apologies for taking a while to get back to this.

Yeah, it seems so. We couldn't figure out a way to get it to work for a private repository unfortunately. In the end, we took a different approach and created the release notes manually in a markdown where the images are called from a directory.

Happy to close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants