Updates #11
Open
Updates #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @crisward Thanks a lot for the pull request! I've not yet had a chance to test the changes, however, from reviewing can you make a few changes for me:
Thanks again for the PR. I'll check out the functionality once I have a bit of time. That will likely be either later this week or next week, as I'm away over the weekend. Matt |
|
ok, will do |
|
@crisward sorry to revive an old thread... but are there any plans to merge this PR? if you don't have time I can gladly take over it |
|
Sorry, I didn't get chance to remove my logo. Just kept on using my fork. https://github.com/crisward/dokku-slack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #7
Added curl installer, incase user doesn't have it
Added slack logo
Updated readme to show global url option
I've tested this in dokku 0.4.4. works well, don't have access to 0.3.x so not sure if I broke anything for users of older versions.