Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version of black? #12

Open
turian opened this issue Jan 5, 2021 · 8 comments
Open

Latest version of black? #12

turian opened this issue Jan 5, 2021 · 8 comments

Comments

@turian
Copy link

turian commented Jan 5, 2021

What version of black does this use? Is it the latest?

On github with this docker I get

Running: black --check src
would reformat /github/workspace/src/ddspdrum/module.py
Oh no! 💥 💔 💥

On my laptop I have the latest pypi black and get

All done! ✨ 🍰 ✨
5 files would be left unchanged.
@ricardochaves
Copy link
Owner

The black version is 19.10b0

What version of action are you using? Depending on the version you use, you may be experiencing this problem. At first it was solved in Isort 5. What version of Isort are you using?

Can you send me your yml?

@turian
Copy link
Author

turian commented Jan 17, 2021

@alvarovn
Copy link

We are having the same issue with black, not using isort. This is our yml:

name: Lint

on:
  pull_request:
    types: ["opened", "edited", "reopened", "synchronize"]

jobs:
  lint:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@master
      - name: python-lint
        uses: ricardochaves/[email protected]
        with:
          use-pylint: false
          use-pycodestyle: false
          use-flake8: true
          use-black: true
          use-mypy: false
          use-isort: false
          extra-flake8-options: "--max-line-length=99"
          extra-black-options: "--line-length=99"

@ricardochaves
Copy link
Owner

Hi @alvarovn , how are u? Can you try the version [email protected], pls?

@alvarovn
Copy link

alvarovn commented Apr 26, 2021

I just tried and have the same issue.
Fedora 33 black version is 20.8b1, which has different results from 19.10b0
Since black results are inconsistent between versions, it would be helpful to be able to choose the version.

@ricardochaves
Copy link
Owner

I put an image with new versions of the libs.
I also added how we can test the action locally in README.md. Could you try and post the results here, please?

@turian
Copy link
Author

turian commented May 5, 2021

@ricardochaves I haven't been able to replicate the bug, I'll let you know if I do.

BTW, you should consider bumping the version of black again. There are more fixes in the latest: psf/black#2199

@dexter2206
Copy link

Are there any plans for the next bump of black version? The version used by this action does not support Python 3.9, i.e. the action fails with a matrix containing Python 3.9 because switch -t py39 is invalid. Black 21.7b0 seems to include py39 as an available option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants