Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESR patched disk compatibility #12

Open
rickgaiser opened this issue Aug 31, 2023 · 0 comments
Open

ESR patched disk compatibility #12

rickgaiser opened this issue Aug 31, 2023 · 0 comments

Comments

@rickgaiser
Copy link
Owner

rickgaiser commented Aug 31, 2023

ESR is now supported, but the compatibility is not as good as ESR, this needs to be fixed.

This is probably caused by the rewritten IOP modules, embedded into this project:

This is the ingame module:
https://github.com/rickgaiser/neutrino/tree/master/iop/esr_cdvdv
Not much has changed, compared to the original:
https://gitlab.com/ffgriever/esr/-/tree/master/cdvdv_sce?ref_type=heads

This is the new combined bios+patch module:
https://github.com/rickgaiser/neutrino/tree/master/iop/esr_pcdvdv
Its based on the merger of the following modules:
https://gitlab.com/ffgriever/esr/-/tree/master/cdvdv_bios?ref_type=heads
https://gitlab.com/ffgriever/esr/-/tree/master/pcdvdv_sce?ref_type=heads

I think the detection of bios version is incorrect / causing issues:

// if (lib->version == 0x101 || lib->version == 0x201) {
if (ioplib_getTableSize(lib) == 62) { // FIXME: is this detection correct ?!
/*
* Detected BIOS version of CDVDMAN
* Do simple hooks and stay resident
*/

} else {
/*
* Detected non-BIOS version of CDVDMAN (game)
* Hook up the other module
*/

I'll leave this issue open for anyone interested to look into it and try to fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant