Issue 84 #172
Open
Issue 84 #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @rubyAnneB on file. In order for us to review and merge your code, please visit https://dev.karakun.com/cla and follow the instructions on that page. |
sclassen
requested changes
Oct 14, 2020
remoting/rico-remoting-server-spring-test/rico-remoting-server-spring-test.gradle
Outdated
Show resolved
Hide resolved
| @@ -21,6 +21,12 @@ dependencies { | |||
| implementation "org.testng:testng:$testngVersion" | |||
There was a problem hiding this comment.
Remove the testng dependency (and version variable) if it is no longer used
...rver-spring-test/src/main/java/dev/rico/internal/server/remoting/test/ClientTestFactory.java
Outdated
Show resolved
Hide resolved
...erver-spring-test/src/main/java/dev/rico/server/remoting/test/SpringJUnitControllerTest.java
Outdated
Show resolved
Hide resolved
...erver-spring-test/src/main/java/dev/rico/server/remoting/test/SpringJUnitControllerTest.java
Outdated
Show resolved
Hide resolved
remoting/rico-remoting-server-spring-test/src/main/java/module-info.java
Outdated
Show resolved
Hide resolved
| @@ -14,4 +14,9 @@ | |||
| requires static java.servlet; | |||
| requires testng; | |||
There was a problem hiding this comment.
if testng is no longer used, then please remove it
There was a problem hiding this comment.
Would like me to delete everything relating to testng? Such as the SpringTestNGControllerTest?
...o-remoting-server-spring-test/src/test/java/dev/rico/server/remoting/test/JUnitDemoTest.java
Outdated
Show resolved
Hide resolved
...o-remoting-server-spring-test/src/test/java/dev/rico/server/remoting/test/JUnitDemoTest.java
Show resolved
Hide resolved
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added dependencies to the module, and converted SpringJUnitControllerTest.java, and JUnitDemoiTest.java to Junit 5. Closes #84