ENABLE_GITHUB_API_PREVIEW only checks against requiresStrictStatusChecks
and not requiresStatusChecks
#1210
Labels
enhancement
New feature or request
What do you want to achieve?
Hey there 👋 I'm trying to have the action go through only when other status checks are complete. These are split into separate workflows, so what ends up happening is that the action passes and the PR is merged before other workflows are finished.
This seems to be happening because only
requiresStrictStatusChecks
is being checked, which looks like it only covers theRequire branches to be up to date before merging
option:merge-me-action/src/common/listBranchProtectionRules.ts
Line 13 in 97e2d51
We don't have this option turned on in our repo, so this returns false even though
mergeStateStatus
isBLOCKED
for the branch and the merge goes through. Is what I'm looking for possible ifrequiresStatusChecks
is also checked?Alternatively, is it possible to expose an option to use the enablePullRequestAutoMerge mutation rather than mergePullRequest?
I'm happy to help contribute to this change 👍
What is the current way of working?
We don't have a workaround right now, other than having the
DEPENDABOT_MINOR
preset in place, but breaking changes still manage to sneak in because our other status checks are being ignored.How much does it hurt?
It's painful! 🙃
The text was updated successfully, but these errors were encountered: