Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist options to user.yaml on api->set_option #760

Closed
rocka opened this issue Nov 12, 2023 · 3 comments
Closed

Persist options to user.yaml on api->set_option #760

rocka opened this issue Nov 12, 2023 · 3 comments

Comments

@rocka
Copy link
Contributor

rocka commented Nov 12, 2023

Is your feature request related to a problem? Please describe.
N/A

Describe the solution you'd like
Persist options to user.yaml when changing option via api->set_option, like #736

Describe alternatives you've considered
N/A

Additional context
fcitx5-rime has a menu to change options via api->set_option, but the options would reset after a maunal sync/deploy. Meanwhile changing options via keyboard shortcut would persist.

@lotem
Copy link
Member

lotem commented Nov 19, 2023

The set_option API function provides access to the internal Context::set_option for library users. It's a programming interface. Saving user preference is a higher level functionality. Not every option in Context is saved; nor should the API function set_option case any side effects other than setting the value in the memory of Context.

Value saved in user.yaml should reflect user's preference; selecting an item in the "Input Schema Switcher" menu does exactly that. In contrast, set_option does not correspond to user's action; it could be set by the program itself.

In that sense, this feature request is not the same change as #736, which only changes the timing for saving user selected schema.

@lotem lotem added the wontfix label Nov 19, 2023
@rocka
Copy link
Contributor Author

rocka commented Nov 19, 2023

If "selecting an item in the 'Input Schema Switcher' menu" reflects user's preference, I wonder why "changing an option in 'options' menu" does not? The option menu is located just below the schema menu, and the schema menu remembers it's previous state. User would expect the option menu to remember its state as well.

@rocka
Copy link
Contributor Author

rocka commented Jan 24, 2024

Closing this since we have patched librime in fcitx5-android/prebuilder#23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants