Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right nav doesn't take the full height of the browser window #65

Closed
djsauble opened this issue Jan 16, 2024 · 2 comments · Fixed by #69
Closed

Right nav doesn't take the full height of the browser window #65

djsauble opened this issue Jan 16, 2024 · 2 comments · Fixed by #69
Assignees

Comments

@djsauble
Copy link

Screenshot 2024-01-16 at 9 25 23 AM

@colegoldsmith
Copy link
Collaborator

@djsauble I set the height that way to make room for the footer scrolling into view at the bottom of the page. If the ToC is full browser height it jumps up when the footer is visible. It's not the worst thing ever but it is a tradeoff with how the sticky element is stacked above a relative element.

@kurtenj Would we want to prioritize giving the ToC more height even though it would jump up a little when scrolling to the bottom?

@djsauble
Copy link
Author

I'd like to see what that transition looks like, but it sounds like a reasonable tradeoff to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants