Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question ragarding z_q_x_st and z_q_x of class VectorQuantizedVAE in modules.py #23

Open
RipeMangoBox opened this issue May 8, 2024 · 1 comment

Comments

@RipeMangoBox
Copy link

RipeMangoBox commented May 8, 2024

Thanks for your great work! I can't figure out the difference between variable (z_ q_ x_ st) and variable (z_q_x) in forward() of class VectorQuantizedVAE.
image

I debug the code but find that both (z_q_x_st) and (z_q_x) need gradient and (z_q_x_st == z_q_x) check is always true.
Does anyone know their difference?

@RipeMangoBox
Copy link
Author

RipeMangoBox commented May 10, 2024

By the way, according to paper Neural Discrete Representation Learning, it's better to change x_tilde as following if there is no difference between (z_q_x_st) and (z_q_x):
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant