Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symlink fixes #76

Merged
merged 8 commits into from
Dec 21, 2023
Merged

Symlink fixes #76

merged 8 commits into from
Dec 21, 2023

Conversation

dreulavelle
Copy link
Member

Too many things to list that this fixes. Will update this description tomorrow...

@dreulavelle dreulavelle self-assigned this Dec 21, 2023
@dreulavelle dreulavelle added enhancement New feature or request high priority Todo or Feature that is considered a higher priority backend This belongs to backend devs labels Dec 21, 2023
Gaisberg
Gaisberg requested changes Dec 21, 2023
View reviewed changes
backend/program/content/mdblist.py Outdated Show resolved Hide resolved
backend/program/media.py Outdated Show resolved Hide resolved
backend/program/scrapers/torrentio.py Outdated Show resolved Hide resolved
backend/program/updaters/trakt.py Outdated Show resolved Hide resolved
@AyushSehrawat AyushSehrawat self-requested a review December 21, 2023 09:24
dreulavelle
dreulavelle commented Dec 21, 2023
View reviewed changes
backend/program/content/plex_watchlist.py Outdated
if imdb_id:
ids.append(imdb_id)
else:
logger.debug("No imdb id found for %s", item.get("title"))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually will need to add tvdb conversion func to accommodate for this. In my testing I found that out of the 50 watchlist items I had, 3 of them were tvdb id's instead of imdb. None were tmdb.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the guid attribute already includes tmdb and tvdb ids but this will do for now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May need your help with this from which guid you're talking about.. the item guid is always empty or filled with Plex's guid, is that the one your talking about?

Gaisberg
Gaisberg requested changes Dec 21, 2023
View reviewed changes
backend/program/content/plex_watchlist.py Outdated
if imdb_id:
ids.append(imdb_id)
else:
logger.debug("No imdb id found for %s", item.get("title"))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the guid attribute already includes tmdb and tvdb ids but this will do for now.

backend/program/media.py Outdated Show resolved Hide resolved
@dreulavelle
Copy link
Member Author

You can merge and deal with conflicts now. I need to look at plex_watchlist more and think about taking a different approach for free users.

@dreulavelle dreulavelle merged commit ca2c089 into main Dec 21, 2023
3 checks passed
@dreulavelle dreulavelle deleted the symlink_fixes branch December 21, 2023 18:28
Gaisberg pushed a commit that referenced this pull request Dec 21, 2023
@dreulavelle
Symlink fixes (#76)
4b64415 
* Fix range index issues on episode check

* Fix docstring

* Added requested_by, and other tweaks.

* Lots of tweaks everywhere. Ready for Review

* make corrections for ids. change to watchlist count.

* Add fixes for requested changes

* remove unnecessary function

* Add latest changes

---------

Co-authored-by: Dreu Lavelle <[email protected]>
Co-authored-by: Spoked <Spoked@localhost>
Gaisberg pushed a commit that referenced this pull request Dec 21, 2023
@dreulavelle
Symlink fixes (#76)
c503b8a 
* Fix range index issues on episode check

* Fix docstring

* Added requested_by, and other tweaks.

* Lots of tweaks everywhere. Ready for Review

* make corrections for ids. change to watchlist count.

* Add fixes for requested changes

* remove unnecessary function

* Add latest changes

---------

Co-authored-by: Dreu Lavelle <[email protected]>
Co-authored-by: Spoked <Spoked@localhost>
AyushSehrawat pushed a commit that referenced this pull request Dec 22, 2023
@dreulavelle @AyushSehrawat
Symlink fixes (#76)
f9adae4 
* Fix range index issues on episode check

* Fix docstring

* Added requested_by, and other tweaks.

* Lots of tweaks everywhere. Ready for Review

* make corrections for ids. change to watchlist count.

* Add fixes for requested changes

* remove unnecessary function

* Add latest changes

---------

Co-authored-by: Dreu Lavelle <[email protected]>
Co-authored-by: Spoked <Spoked@localhost>
AyushSehrawat pushed a commit that referenced this pull request Dec 22, 2023
@dreulavelle @AyushSehrawat
Symlink fixes (#76)
8646a00 
* Fix range index issues on episode check

* Fix docstring

* Added requested_by, and other tweaks.

* Lots of tweaks everywhere. Ready for Review

* make corrections for ids. change to watchlist count.

* Add fixes for requested changes

* remove unnecessary function

* Add latest changes

---------

Co-authored-by: Dreu Lavelle <[email protected]>
Co-authored-by: Spoked <Spoked@localhost>
dreulavelle added a commit that referenced this pull request Dec 23, 2023
@AyushSehrawat @Gaisberg
@dreulavelle @KingPin
feat: frontend improvements,, added settings! (#86)
2641de0 
* feat: added service status and other minor improvements

* Concurrency and show fixes (#52)

* Add concurrency, fix shows

* Run prettier on default_settings.json

* Better logging, added item_ids and extended info endpoint for shows

---------

Co-authored-by: Gaisberg <None>

* Torrentio rate limiter improvements, realdebrid downloading improvements

* Aired_at == None for not released seasons

* Move mount settings to general settings, fix section updating for only our sections

* Remove unused settings

* Get plex items from only wanted sections

* Add symlinking guide to readme

* Docker (#70)

* add makefile. fix entrypoint. dockerfile needs entrypoint execution tweak though.

* Fixed entrypoint. Fixed user being set to root

* Fix readme

* Done. Can now set PUID/PGID correctly. Updated Dev Env makefile.

* Sneak in update lol

* Update help

* Correct syntax for update.

---------

Co-authored-by: Spoked <Spoked@localhost>

* fix: remove auto reload, causes issues sometimes,,, will add later

* Feat: added settings page and some other minor improvements

* Feat: added settings page and some other minor improvements

* deps: updated tailwindcss

* feat: added partial settings form

* Symlink fixes (#75)

* Fix range index issues on episode check

* Fix docstring

---------

Co-authored-by: Dreu Lavelle <[email protected]>

* Symlink fixes (#76)

* Fix range index issues on episode check

* Fix docstring

* Added requested_by, and other tweaks.

* Lots of tweaks everywhere. Ready for Review

* make corrections for ids. change to watchlist count.

* Add fixes for requested changes

* remove unnecessary function

* Add latest changes

---------

Co-authored-by: Dreu Lavelle <[email protected]>
Co-authored-by: Spoked <Spoked@localhost>

* tidy imports (#79)

Co-authored-by: Dreu Lavelle <[email protected]>

* Update github actions with multiarch etc (#80)

* multiarch initial commit

* remove armv7 for testing

* enable pushing to registry

* add explicit permissions to GHA (#81)

* Add tweaks, add some kind of parsing for torrents etc.

* Symlink fixes (#76)

* Fix range index issues on episode check

* Fix docstring

* Added requested_by, and other tweaks.

* Lots of tweaks everywhere. Ready for Review

* make corrections for ids. change to watchlist count.

* Add fixes for requested changes

* remove unnecessary function

* Add latest changes

---------

Co-authored-by: Dreu Lavelle <[email protected]>
Co-authored-by: Spoked <Spoked@localhost>

* Address slow loading times and cpu usage, hacky but what the hell

* fix watchlist. needs rewrite to use plexapi. will fix later.

* Fix scraping logging indent

* feat: partial changes

* feat: added general & about in settings

* set scrape type to series instad of show. invalid url before. (#85)

Co-authored-by: Dreu Lavelle <[email protected]>

* chore: changed status code, minor changes

* feat: added plex settings

* chore: minor change

* fix origin in entrypoint. set makefile to host with mount.

* remove gif

---------

Co-authored-by: Gaisberg <[email protected]>
Co-authored-by: Gaisberg <None>
Co-authored-by: Spoked <[email protected]>
Co-authored-by: Spoked <Spoked@localhost>
Co-authored-by: Dreu Lavelle <[email protected]>
Co-authored-by: KingPin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gaisberg Gaisberg Gaisberg approved these changes

@AyushSehrawat AyushSehrawat Awaiting requested review from AyushSehrawat

Assignees

@dreulavelle dreulavelle

Labels
backend This belongs to backend devs enhancement New feature or request high priority Todo or Feature that is considered a higher priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dreulavelle @AyushSehrawat @Gaisberg