Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constify RzBuffer API #4817

Open
Rot127 opened this issue Jan 2, 2025 · 0 comments
Open

Constify RzBuffer API #4817

Rot127 opened this issue Jan 2, 2025 · 0 comments
Labels
enhancement New feature or request refactor Refactoring requests RzUtil
Milestone

Comments

@Rot127
Copy link
Member

Rot127 commented Jan 2, 2025

Is your feature request related to a problem? Please describe.

The RzBuffer API doesn't pass RzBuffer pointers as const. Even if if it shouldn't (e.g. for rz_buf_size).

This is a problem. Because it prevents users of the API to also pass the pointers without const or do casts before using the API.

Both is not nice.

Describe the solution you'd like

Refactor the API to use const where possible.

Describe alternatives you've considered

None. I can't come up with a good reason to not do it.

Additional context

None

@Rot127 Rot127 added enhancement New feature or request refactor Refactoring requests RzUtil labels Jan 2, 2025
@Rot127 Rot127 added this to the 1.0.0 milestone Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Refactoring requests RzUtil
Projects
None yet
Development

No branches or pull requests

1 participant