Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long Line Marker default #1113

Closed
kofifus opened this issue Apr 10, 2019 · 13 comments
Closed

Long Line Marker default #1113

kofifus opened this issue Apr 10, 2019 · 13 comments

Comments

@kofifus
Copy link

kofifus commented Apr 10, 2019

I've been trying to get my colleagues here to use Notepad3 and have been watching as they go through installation and first time run.

Without fail all of them were surprised by the long line marker that is on by default on a fresh install, either they get scared or think there's something wrong with their screen !

I suggest for the long line marker to be off by default on a fresh install.

Thanks!

@RaiKoHoff
Copy link
Collaborator

RaiKoHoff commented Apr 18, 2019

Yes, we can do that - any "veto" ?

Ed.: Two possibilities:

  1. Keep default (=ON) and just put it to OFF in the default initial .ini-file.
  2. Change the default internally (=OFF).

Impact:

  1. No impact for users who have a already custized .ini-file.
    But this would be against the policy to deliver a "lean and mean" (default) .ini-file.
  2. Users who have a .ini-file with LongLineMarker set (default: no [Settings] written to .ini-file) are losing their LongLineMarker now (no settings means now OFF). 😲

@hpwamr
Copy link
Collaborator

hpwamr commented Apr 18, 2019

Suppress the Long Line Marker is only 1 click (View -> Click on "Long Line Marker") or Ctrl+Shift+L.
It's a part of the ADN of Notepad3, I vote to keep it unchanged ! 😃

@kofifus
Copy link
Author

kofifus commented Apr 18, 2019

It's one click if you know what the marker is and know the shortcut .. on first install to someone new to notepad3 its a strange yellow line on the screen ..

IMO out of the box notepad3 should not have any such 'surprises' as they are evidently confusing..

Thanks!

@craigo-
Copy link

craigo- commented Apr 19, 2019

I understand that a while ago there was some discussion (possibly not on this medium) about showcasing what Notepad3 can do, right out of the box. The long line marker setting was one of a number of features that were turned on as a result.

I'm happy with that decision. But I am also sympathetic to the user experience that @kofifus is describing.

Suggestion: we keep things as they are, but on first launch the application offers a help page (likely on rizonesoft.com) that describes the out-of-box experience. It could literally just be a screenshot with callout arrows indicating what the most important UI elements are (including the long line marker). I would recommend that the Notepad3 dialogue only be offered once, and is not displayed again once the user has dismissed it. Perhaps the same link could be added to the Help -> About... dialogue, and this be mentioned in the first-run dialogue should the user wish to access it again.

The page and image would require maintenance. I'm happy to put my hand up and provide an annotated screenshot...

@hpwamr
Copy link
Collaborator

hpwamr commented Apr 19, 2019

Suggestion: we keep things as they are, but on first launch the application offers a help page (likely on rizonesoft.com) that describes the out-of-box experience. It could literally just be a screenshot with callout arrows indicating what the most important UI elements are (including the long line marker). I would recommend that the Notepad3 dialogue only be offered once, and is not displayed again once the user has dismissed it. Perhaps the same link could be added to the Help -> About... dialogue, and this be mentioned in the first-run dialogue should the user wish to access it again.

The page and image would require maintenance. I'm happy to put my hand up and provide an annotated screenshot...

@craigo- All of this seems me an excellent suggestion, 😃

I thing it's possible to put the Screenshot in "GitHub/Notepad3/Doc" to facilitate the maintenance by PR.
Also maybe, working with distinct layers. E.g.: 1 for the Screenshot + one by MUI Languages).
I suggest to use "Paint.net" to edit the Screenshot (already use for Notepad3Portabe Splash).

Let's see the vote or reactions of other users of Notepad3. 🤔

@craigo-
Copy link

craigo- commented Apr 19, 2019

Good idea about the layered image.

@kofifus
Copy link
Author

kofifus commented Apr 20, 2019

Wow I didn't expect so many reactions to this simple request :)

I still don't understand why there is the view that this should be on by default ? what about show linespaces, show line endings, and other such options which are off by default ?

To me the long line marker is something I just always immediately turn off and never turn on again. I think it's a nice thing to have in case someone wants it but most people will want it off. I may of course be wrong on this ..

@RaiKoHoff
Copy link
Collaborator

I think it does make sense to disable the LongLineMarker by default.
By using the the .ini-file version mechanism (upcoming Version 2) the behavior of already customized Notepad3s can be preserved.
Please test beta version _5.19.425.1673_develop (see beta-channel access #1129).

@RaiKoHoff
Copy link
Collaborator

Please test beta version _5.19.427.1679_develop (see beta-channel access #1129).

@hpwamr
Copy link
Collaborator

hpwamr commented Apr 28, 2019

Hell @RaiKoHoff
I think the conversion mechanism to "SettingsVersion=2" is not working correctly. 🤔

  • Notepad3 version _5.19.427.1679_develop Out-of-the-box --> No Long Line Marker 👍

Edit Notepad3.ini and change "SettingsVersion=2" to "SettingsVersion=1"

  • First start --> Long Line Marker is present 👍
  • Close, restart --> Long Line Marker has disappeared 👎
    I think because the key "MarkLongLines=1" was not written in [Settings] ?

@hpwamr
Copy link
Collaborator

hpwamr commented Apr 28, 2019

Test Notepad3 (64-bit) v5.19.428.1680 develop, works as designed and requested. 😃

As far as I am concerned, this issue may be closed....

@kofifus
Copy link
Author

kofifus commented Apr 28, 2019

works well thanks!

@kofifus kofifus closed this as completed Apr 28, 2019
@hpwamr
Copy link
Collaborator

hpwamr commented May 1, 2019

craigo- commented [13 days ago]

I understand that a while ago there was some discussion (possibly not on this medium) about showcasing what Notepad3 can do, right out of the box. The long line marker setting was one of a number of features that were turned on as a result.

Hello @craigo- , I've I found the article you refer to: #722 (comment)

The reason for changes was, to get a "nicer" first (initial) impression of Notepad3 on startup and first use for new users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants