Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pin icon on the title when "always on top" is enabled #1185

Closed
wdhwg001 opened this issue May 8, 2019 · 13 comments
Closed

Add a pin icon on the title when "always on top" is enabled #1185

wdhwg001 opened this issue May 8, 2019 · 13 comments

Comments

@wdhwg001
Copy link

wdhwg001 commented May 8, 2019

I used the Alt+T function a lot, and I realize that it would be useful to tell from the title whether a window is "pinned" or not.

@RaiKoHoff
Copy link
Collaborator

I don't like these "extra" buttons in the title-bar, cause: when design changed (Win7 -> Win10) they become ugly.
Suggestion: we can add a tool-bar button (pin), which has a different image when activated (normal vs. hot bitmap <-> "unpinned" vs. "pinned").
This will have a similar but "nicer" visual effect.
(@rizonesoft : do you have time to create corresponding bitmap extension for the default toolbars?)

@RaiKoHoff
Copy link
Collaborator

Please test beta version _5.19.514.1670_RC (see beta-channel access #1129).
You have to enable the toolbar-button (customizing toolbar).
The design of the button may change for release version (-> @rizonesoft )

@hpwamr
Copy link
Collaborator

hpwamr commented May 14, 2019

I suggest positioning (default position) this icon to the left of the Exit icon.

Let's see the vote or reactions of other users of Notepad3. 🤔

@craigo-
Copy link

craigo- commented May 14, 2019

RC builds 1671 and 1672: you don't appear to have to turn on the Always On Top toolbar button; it is there by default. Is that the intent?

It's probably a button that I will disable, although I'm leaving it there for now to see how I feel... It's not a function I have a use case for.

I agree with @hpwamr's suggestion to move the button to the second-to-last position, keeping the Exit button on the far right (although that too is a button I disable; the standard X in the top right of the window is enough for me).

@wdhwg001
Copy link
Author

@RaiKoHoff It might feel a bit weird to have the transition animation since all others are just static icons, maybe we remove it by just letting the icon become pinned only when notepad is pinned.

@RaiKoHoff
Copy link
Collaborator

RaiKoHoff commented May 15, 2019

All toolbar-button icons are animated (normal <-> hot, change on mouse hoover or getting checked on active state). Only difference, the other buttons have same icon (normal and hot) and so they seemed to be static vs. animated, only the "Always On Top" button has a different image...
(Ed.: so the "animation" is a Windows thing changing between "normal<->hot")
Ed2: If you want to have a "static" behavior (like the other icons) you have to decide for one icon for both states (active and not-active) to have the same icon (either "pinned" or "not-pinned"))!
Ed3: A 3rd state is "disabled" (grayed-out), like for save-button when file has not changed, but this is not applicable for "Always On Top" button, cause if "disabled", it is not clickable anymore (to pin/unpin).

@wdhwg001
Copy link
Author

@RaiKoHoff How about we just use:
"A pressed button" -> "Pinned"
"A normal button" -> "Not-pinned"
"A gray button" -> "Disabled"
And keep the icon static.

@RaiKoHoff
Copy link
Collaborator

Maybe I didn't express myself clearly:
"Static" icon means: You have to decide for ONE icon ("Pinned" or "Not-Pinned") for all states.
Using different icons, you get the "animation" automatically by Windows's UI behavior.

@wdhwg001
Copy link
Author

@RaiKoHoff I think I would prefer the "not-pinned" icon, which looks more like a regular pin.
BTW, perhaps we should put the pin button on the left of the exit? I'm not sure...

@RaiKoHoff
Copy link
Collaborator

What is about a "static" "Not-Pinned" icon, having a color-change (blue->red) if activated (always on top) ?

By the way, you can "play around" with different scenarios, by using the "external Toolbar" feature (normal/hot/disabled) in .ini-file:

[Toolbar Images]
BitmapDefault=Toolbar.bmp
BitmapHot=ToolbarHot.bmp
BitmapDisabled=ToolbarDisabled.bmp

@garoto
Copy link

garoto commented May 15, 2019

What about a textual indicator on the title bar kinda like mockup below:

(T)  myfile.txt [C:\] - Notepad3 (Administrator)

@hpwamr
Copy link
Collaborator

hpwamr commented May 15, 2019

Wow, 11 comments for "a nice to have" "Always On Top" icon ! 😉

The design of the button may change for release version (-> @rizonesoft )

Ed: Don't forget, as mentioned above, the design is subject to change with the final version.

As far as I am concerned, this issue may be closed, no ! 🤔

@hpwamr hpwamr closed this as completed May 16, 2019
@craigo-
Copy link

craigo- commented May 19, 2019

By the way, I like the new icon in build 5.19.519.1713 RC. I think it fits in better with the style of the other icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants