Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When selecting a group of text from left to right, cursor is off by one space... #1196

Closed
MelchiorGaspar opened this issue May 11, 2019 · 12 comments

Comments

@MelchiorGaspar
Copy link
Contributor

MelchiorGaspar commented May 11, 2019

I am have noticed this for a while now..
I am using: Notepad 3 (v5.19.507.1696_RC)(Portable)(DevBuild)(x64)

I have copies of older NP3 back to version: Notepad 3 (v5.19.226.1621)(Portable)(DevBuild)(x64)
it still occurs in this old version..

the cursor is on the left side of the final selected digit on the right end of the selected text..
is this intentional or is it a bug?

I'm running Windows 7 ULTIMATE (SP1)(X64)..
ask for any additional info needed..

@RaiKoHoff
Copy link
Collaborator

I am not able to reproduce the described behavior (Win10, v1809) 🤔.
Neither with normal caret nor block-caret and not by choosing right-to-left (bidirectional technology).
Please provide your .ini-file (anonymity: remove file paths history, etc.)

@MelchiorGaspar
Copy link
Contributor Author

MelchiorGaspar commented May 12, 2019

Notepad3.ini.zip
really?! wow... I was sure this was gonna be an easy report...

edit:
I just tested NP3 with a fresh copy of ini... it doesn't happen.. so it seems to be an ini issue like the last one I reported... :-(

@jupester
Copy link

I also encountered this problem when upgrading and using and old ini file, it took me a little while to work out the cause, I fixed it by adding this to the Default Text Scheme | Caret settings:

ovrbar

@RaiKoHoff
Copy link
Collaborator

Bug introduced with feature "remove key-value in settings, if it equals default",
"ovrbar" should be default, so it should not be needed here ...

@MelchiorGaspar
Copy link
Contributor Author

MelchiorGaspar commented May 12, 2019

ooh cool so its something fixable..
I tried adding ovrbar to caret settings and it now works like it should.. thx for the info @jupester.

This line disappeared from my settings file when I added that...
Caret (Color, Size 1-3)=size:1

@RaiKoHoff
Copy link
Collaborator

Changed "ovrbar" to "ovrblck", (better description):
For the caret settings:

  • empty: you get a "line" in insert mode and a "bar" in over-strike mode.
  • "block": you get a "block" in insert mode and a "bar" in over-strike mode.
  • "ovrblck": you get a "line" in insert mode and a "block" in over-strike mode.
  • "block; ovrblck;": you get a "block" in insert mode and a "block" in over-strike mode.

The "ovrblck" only mode ("block" in over-strike mode) has the bug described in this issue, seemed to be a Scintilla problem 🤔 .

Please test beta version _5.19.512.1699_RC (see beta-channel access #1129).

@RaiKoHoff RaiKoHoff changed the title [BUG?] When selecting a group of text from left to right, cursor is off by one space... When selecting a group of text from left to right, cursor is off by one space... May 12, 2019
@MelchiorGaspar
Copy link
Contributor Author

ok it seems to be working normally now...
you can close this if that is all that needs to be done?

@zufuliu
Copy link

zufuliu commented Jun 3, 2019

This is bug in Scintilla (not fixed at the moment) https://sourceforge.net/p/scintilla/bugs/2106/

@MelchiorGaspar
Copy link
Contributor Author

@zufuliu ok

@zufuliu
Copy link

zufuliu commented Jun 27, 2019

This was fixed in Scintilla
https://sourceforge.net/p/scintilla/bugs/2106/
https://sourceforge.net/p/scintilla/bugs/1924/

A new caret style CARETSTYLE_BLOCK_AFTER is added to allow draw block caret outside selection.

@RaiKoHoff
Copy link
Collaborator

Current Scintilla development (4.1.8) has been integrated in alpha/experimental development, feel free to test version Notepad3_5.19.628.2261_Oniguruma (for beta channel access, see #1129).
(Using Scintilla version 4.1.8 for upcoming release (master branch) will be discussed).

@MelchiorGaspar
Copy link
Contributor Author

ok.. so this can be closed now I guess...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants