Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable the hyperlink hotspots tooltip #1213

Closed
omega32 opened this issue May 18, 2019 · 11 comments
Closed

Option to disable the hyperlink hotspots tooltip #1213

omega32 opened this issue May 18, 2019 · 11 comments

Comments

@omega32
Copy link

omega32 commented May 18, 2019

Hi. Is there an option to disable the new hyperlink hotspot tooltip, or any plans to implement one?
(Ctrl + Click to open link in browser).
I find it quite annoying. Thanks.

@hpwamr
Copy link
Collaborator

hpwamr commented May 18, 2019

Hello @RaiKoHoff,
I agree with @omega32 , it's quite distracting,
My opinion, remove it completely, "Hyperlink hover rendering" is sufficient. 😉

Ed.: But if you keep it, please don't repeat the URL in the Calltip box (just the msg: "Ctrl + Click to open link in browser").

@RaiKoHoff
Copy link
Collaborator

It is a kind of standard, that hovering over a link will show the target of the link in a tooltip.
It is clear, that for Notepad3 (vs. e.g. websites) the target and the textual representation are the same,
so I will add an option to disable that. For the rookie user, it should be shown, so default will be ON.

@hpwamr
Copy link
Collaborator

hpwamr commented May 18, 2019

It is a kind of standard, that hovering over a link will show the target of the link in a tooltip.

You're right, in Visual Studio, this is the standard, except that the underlining of the URL is not highlighted when you hover over the URL. 🤔

@RaiKoHoff
Copy link
Collaborator

Please test beta version _5.19.518.1710_RC (see beta-channel access #1129).

@hpwamr
Copy link
Collaborator

hpwamr commented May 18, 2019

Hi @RaiKoHoff ,
Thanks for the new design of the Hyperlink (aka MS VS, clean and discreet, idem for 2ND Default)
Also, thanks for the new option: View -> Display -> Show Hyperlink Tooltip

As far as I am concerned, this issue may be closed.... 🤔

@omega32
Copy link
Author

omega32 commented May 18, 2019

Great. I like the new hyperlink styling a bit better.
And thanks for the option to disable it. 👍

One more suggestion, though.
I think what I dislike the most about the implementation of the tooltip, is not the tooltip itself, but the flickering of the cursor.

When you hover the hyperlink, the cursor changes from IBeam (text selection) to hand and back to IBeam. Also, when it's changing back from hand to IBeam, there seems to be some sort of flickering.

I think a good way to handle this is how Visual Studio does it. When you hover a hyperlink in VS, the cursor remains IBeam unless you press CTRL. Only when CTRL is down the cursor changes to a hand, suggesting with a visual cue that if you click, the link will open.

@RaiKoHoff
Copy link
Collaborator

Please test beta version _5.19.519.1712_RC (see beta-channel access #1129).

@omega32
Copy link
Author

omega32 commented May 19, 2019

Great. Much better this way, I think. 👍
And, although I'm disabling the tooltip, I don't find it annoying anymore. Looks great actually.

@RaiKoHoff
Copy link
Collaborator

Scintilla bundled the "hand cursor" with the hotspot/indicator:hover styling (no API/option to change this), so I have to change Scintilla's source code for that (which I don't really like, cause it is effort to merge a new Scintilla version into Notepad3's code base, if these places change in future),
but the changes were only small, that is OK. 👍

@omega32
Copy link
Author

omega32 commented May 22, 2019

Awesome. You got it quite fast considering you had to modify Scintilla's source code.
I'll try to lobby for them to include a way to handle this without the need to change the code.

@hpwamr
Copy link
Collaborator

hpwamr commented May 23, 2019

As far as I am concerned, this issue may be closed....

@omega32 omega32 closed this as completed May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants