Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TD2c in set_tradingdays #53

Open
AQLT opened this issue Jul 8, 2024 · 0 comments
Open

TD2c in set_tradingdays #53

AQLT opened this issue Jul 8, 2024 · 0 comments

Comments

@AQLT
Copy link
Contributor

AQLT commented Jul 8, 2024

The TD2c option seems missing from the set_tradingdays(option=) parameter.
Maybe we should also enable the TD2 option (for working days) and TD7 (for tradingdays) adding those options in:

rjd3toolkit/R/spec_regarima.R

Lines 1023 to 1025 in e44c1ea

option <- match.arg(toupper(option)[1],
choices = c("TRADINGDAYS", "WORKINGDAYS", "NONE","USERDEFINED",
"TD3", "TD3C", "TD4", "HOLIDAYS"))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant