Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

residual trading days tests in JDemetra+ 2.x.y #7

Closed
AQLT opened this issue Sep 26, 2023 · 1 comment
Closed

residual trading days tests in JDemetra+ 2.x.y #7

AQLT opened this issue Sep 26, 2023 · 1 comment

Comments

@AQLT
Copy link
Contributor

AQLT commented Sep 26, 2023

In JDemetra+ 2.x.y, the residual trading days tests was perform with an AR(1) model estimated by OLS while in rjd3toolkit it is now estimated using another method (ML). In previous versions of rjd3toolkit there was a model called AR which was also using an ols model :
https://github.com/jdemetra/jdemetra-core/blob/2b12a60f0b7135f00fab7031233ddf93f33045b6/demetra-sa/demetra-sa-r/src/main/java/demetra/sa/r/TradingDaysTests.java#L33-L38
If think it would be usefull to keep this model in order to be able to reproduce the tests used in JDemetra+ 2.x.y

@palatej
Copy link
Contributor

palatej commented Apr 19, 2024

Hi Alain,

I suppressed the test because it was wrong (as the test in JD2). More specifically, the model was:
y(t)= a + by(t-1) + ctd(t) + e(t).

A more correct model should be:
y(t) - phiy(t-1)=a + b(td(t) - phi*td(t-1)) + e(t)

The new test is based on phi = 1.
In practice, setting phi = 1 doesn't change much the result of the test and it is more robust (and significantly faster).
To be noted that for stationary series, I put phi = 0

@palatej palatej closed this as completed Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants