Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete arima spec in output #27

Closed
merangelik opened this issue Nov 16, 2023 · 3 comments
Closed

Incomplete arima spec in output #27

merangelik opened this issue Nov 16, 2023 · 3 comments

Comments

@merangelik
Copy link

Hi,

should output$preprocessing$description$arimaalso contain the remaining p, q, bp and bq values of the arima spec instead of only dand bd? Or do these values mean something completely different?

> userdefined_default <- c(
+   "y", "t", "sa", "s", "i", "cal", "y_f", "t_f", "sa_f", "s_f", 
+   "cal_f", "y_ef",
+   "decomposition.d6", "decomposition.d7", "decomposition.d9","decomposition.d13",
+   "decomposition.mode", "arima.p","arima.d", "arima.q" ,"arima.bp" , "arima.bd","arima.bq"
+ )
> output <- fast_x13(
+   ts = AirPassengers,
+   spec = "rsa1",# dieser Parameter anscheinend nicht case sensitive
+   context = NULL,
+   userdefined = userdefined_default
+ )
> 
> names(output$preprocessing$description$arima)
[1] "period" "d"      "bd"     "phi"    "theta"  "bphi"   "btheta"
@AQLT
Copy link
Contributor

AQLT commented Nov 17, 2023

The values of p, q, bp, bq can be obtained with phi, theta, bphi and btheta. See for example what is done in rjd3report or in rjd3toolkit print methods'
https://github.com/AQLT/rjd3report/blob/master/R/manipulation.R#L48-L64

@merangelik
Copy link
Author

merangelik commented Nov 20, 2023

Ah, thanks! Good idea to have a look at the print methods!
Is the reason for such a structure to keep the output objects as small as possible with as much information as possible?

@annasmyk
Copy link
Member

I think we can close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants