-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reintegrate with distill package #9
Comments
Hi @yihui, thanks for chatting about these changes with us. An ordering of priority for changes needed in R Journal articles to use distill are:
The other items are more of a wishlist.
|
Thanks @mitchelloharawild! I'll defer the response to other items to @cderv. For arbitrary appendices, does the |
Appendices would be added by the output format, possibly based on the YAML (CRAN / Bioc packages and task views): Or possibly without a YAML entry (for example, Maybe it's possible for the output format to add contents to the document's body to provide arbitrary appendices, but it'd be nicer if there was a simpler method. |
Okay got it. Yes, I agree that the YAML approach (or |
Hi @mitchelloharawild ! Know that I will look at the two main points describe in #9 (comment) tomorrow. Hopefully we'll get something working for you for next week. I'll ping you in the relevant PR for you to test and adapt in here in a companion PR. does that sound ok to you ? We could try to find a time to meet also if you want us to discuss the implementation. That would be morning for me and probably evening for you. (I am in France) |
Hi @mitchelloharawild , Example repo is here: https://github.com/cderv/rjdistill Most of the tweaks happens in the output format definition. Then I do a lot using JS directly. Specifically for some parts hard to tweak. I am having a result close to what you are looking I believe. I need to show that to you, and test it in a website. I only tested the article format on a single doc. Some insights on what we could do or not in distill after that to try generalize. Google scholar dateLines 481 to 482 in 6392af7
Maybe we need two fields in the YAML : date:
date_online: We could map to both google scholar dates Tags on Listing pageLike in https://distill.pub/ Currently We would need to a second set of tags shown on listing page. type:
- tag 1
- tag 2 or more precisely listing_categories:
- tag 1
- tag 2 If defined it would be shown on listing page. listing:
tags:
- tag 1
- tag 2 Custom appendixThe current generic behavior works quite well and can be used in a custom formats. I used it in a pre_processor step in the output format to append custom markdown content to the intermediary file. See the demo package; custom d-bylineAdding arbitrary fields in by-line is not as easy as I thought. I think we could make a similar system as appendices by having some content like this ### My new byline header {.byline}
Content which would be moved to byline part. By I recognize this could be weird to write in the document. 🤔 byline:
- name: New header
content: value but really the styling will be off and this would require a custom CSS anyway. And even JS to change the order if necessary. AbstractDo we really need to add a abstract ? Isn't the description field enough ? description:
abstract: We could easily add this new part with |
This hard fork is motivated by the need for some structural changes needed in the distill package. With support from the RStudio distill developers, it should be possible to generalise the distill package in a way that allows The R Journal to extend it rather than fork it.
This issue summarises the changes made in rjdistill which would need to (or should) be generalised in distill.
d-byline
metadata.Option forIt is probably better to use a different output for this (like how postcards is used).seal=FALSE
to remove generated titles from info pages?Changes that would still occur in rjdistill/rjtools as an extension of distill:
rticles::rjournal_article()
todistill::distill_article()
. For example,orcid_id
->orcid
.\pkg{*}
,\CRANpkg{*}
,\BIOpkg{*}
The text was updated successfully, but these errors were encountered: