Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing TS types #261

Open
knownasilya opened this issue Jul 12, 2021 · 3 comments
Open

Missing TS types #261

knownasilya opened this issue Jul 12, 2021 · 3 comments

Comments

@knownasilya
Copy link
Contributor

Seems like no border styles are in the options, like borderWidth and borderColor on cells and rows.
@knownasilya
Copy link
Contributor Author

knownasilya commented Jul 12, 2021 •
edited
Loading

Also I think widths should take ${number}% string type

@rkusa
Copy link
Owner

rkusa commented Jul 29, 2021

Seems like no border styles are in the options, like borderWidth and borderColor on cells and rows.

You are right, this is indeed missing for table cells and rows - thanks for the report!

Also I think widths should take ${number}% string type

I might have forgotten about it, but I don't think that pdfjs supports percentage values for widths - only null (or *) as a way to take up the rest of the space.

@knownasilya
Copy link
Contributor Author

but I don't think that pdfjs supports percentage values for widths

It used to, seems like the functionality was removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@knownasilya @rkusa