Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzzy matching oddities #33

Open
dmfay opened this issue Nov 22, 2022 · 0 comments
Open

fuzzy matching oddities #33

dmfay opened this issue Nov 22, 2022 · 0 comments

Comments

@dmfay
Copy link

dmfay commented Nov 22, 2022

hi! I'm trying this out after hop and really like it so far, but I've noticed and been able to reproduce a couple of issues with the matcher. Both on this sample text:

hi link @definition Normal
hi link @definition.constant Constant
hi link @definition.function Function
hi link @definition.method Function
hi link @definition.var Normal
hi link @definition.parameter Identifier
hi link @definition.macro Macro
hi link @definition.type Type
hi link @definition.field Todo
hi link @definition.enum Structure
hi link @definition.namespace Define
hi link @definition.import Include
hi link @definition.associated Todo

(extra lines on purpose)

  1. with cursor on an empty line, pounce and search dfnt. All instances of definition match, but the "best" match is on line 8 instead of nearest to the cursor. The line 8 match also ignores the first n and extends out to the t in type; there are other cases in which this could happen (e.g. definition.import), but it doesn't.
    1669086886
  2. with cursor on the last line with text, pounce and search dfnt. Only lines 8 and 13 remain candidates by the last character even though all instances of definition matched above. The extended line 8 match is also evident again.
    1669086868
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant