Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling **kwargs #334

Open
TimotheeMathieu opened this issue Jul 10, 2023 · 3 comments
Open

Handling **kwargs #334

TimotheeMathieu opened this issue Jul 10, 2023 · 3 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request Marathon To do during Marathon style This is a code style issue

Comments

@TimotheeMathieu
Copy link
Collaborator

TimotheeMathieu commented Jul 10, 2023 •
edited
Loading

It is not clear for a newcomer what are **kwargs and what can we put in them.
@KohlerHECTOR KohlerHECTOR added documentation Improvements or additions to documentation enhancement New feature or request style This is a code style issue Marathon To do during Marathon labels Jul 13, 2023
@KohlerHECTOR
Copy link
Collaborator

Should we just remove them when we can ? @omardrwch

@omardrwch
Copy link
Member

Remove them from where? From Agent only? When designing Agent, I required**kwargs in case AgentManager needed to send some extra parameters to the agent's constructor, that were not handled by the user.
This can probably be replaced by (private) setters.

@TimotheeMathieu
Copy link
Collaborator Author

TimotheeMathieu commented Jul 14, 2023 •
edited
Loading

I understand the idea but these kwargs are very cryptic to newcommers (and even for me, I have to read the code every time to know what can go in there). A lot of the new people trying rlberry in the team were wondering what are kwargs ? What should I put in there ? What can I put in there ?

@riiswa riiswa mentioned this issue Jul 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request Marathon To do during Marathon style This is a code style issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@omardrwch @TimotheeMathieu @KohlerHECTOR