-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default value for eval_horizon #337
Comments
I'd keep it as large as possible (as now) and put a time limit in the environment, if necessary. To avoid hiding these choices from the user. |
Yes it should be 500 but could be change, it does not really matter. |
Why should this be 500? @KohlerHECTOR |
This should be 500 because 500 is the default for all control gym environment and is used in most benchmarks of control environments. This may be a deep rl thing. I think that there is no default in tabular rl so I think it is best to just go with the default that exists in deep rl. |
If the gym environment has already a time limit (at 500), any |
@omardrwch Sorry for the authoritarian closing. I think indeed 500 is some kind of industry standard let us say. But in any case, this could be changed by the user when they code their experiments. Plus evaluation is pretty costly so on the contrary I would keep it as low as possible :) |
No worries! Ok for 500, but then let's put warning if we've reached 500 and the episode is not terminated. |
Should the default for eval_horizon be 500 ?
The text was updated successfully, but these errors were encountered: