Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Adapt new sources from qbittorrent's search plugins #112

Open
1 of 3 tasks
jtrv opened this issue Jan 27, 2023 · 4 comments
Open
1 of 3 tasks

[Feature Request] Adapt new sources from qbittorrent's search plugins #112

jtrv opened this issue Jan 27, 2023 · 4 comments

Comments

@jtrv
Copy link
Contributor

jtrv commented Jan 27, 2023

https://github.com/qbittorrent/search-plugins/wiki/Unofficial-search-plugins

In my testing the best of these sources seems to be

@rnestler
Copy link
Owner

torrent-csv should be fairly easy to add, since it is just another JSON API: https://github.com/qbittorrent/search-plugins/blob/master/nova3/engines/torrentscsv.py

The other two look like HTML parsing is necessary.

@jtrv
Copy link
Contributor Author

jtrv commented Jan 27, 2023

I hadn't looked at the code yet, that's great to know! In my experience torrent-csv usually nets the best results too, so that's a perfect low-hanging fruit. I might take a crack at it since I'm learning Rust.

Would you be open to the inclusion of an html parser in this project for other sources? Or is there a preferred html parsing crate I should use?

@rnestler
Copy link
Owner

I hadn't looked at the code yet, that's great to know! In my experience torrent-csv usually nets the best results too, so that's a perfect low-hanging fruit. I might take a crack at it since I'm learning Rust.

Take a look at https://github.com/rnestler/attractorr/blob/master/src/search_providers/pirate_bay_search.rs which is a quite simple api.

For YTS I implemented it in a separate crate: https://github.com/rnestler/yts-api-rs but I'm not sure if this is really worth it.

Would you be open to the inclusion of an html parser in this project for other sources? Or is there a preferred html parsing crate I should use?

Until #38 we used https://crates.io/crates/select for HTML parsing for pirate bay which I found quite nice to use.

@ShayBox
Copy link

ShayBox commented Dec 15, 2023

Jackett is probably the best project to target for the best searchability, but it might be outside the scope of this project and require a new dedicated project. https://github.com/Jackett/Jackett

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants