Wrapped text shifts left when company auto-complete comes up

[codygman]

emacs: 28.0.50
olivetti version:

;; Package-Version: 20200702.601
;; Version: 1.11.1

Given text like this and a configuration where olivetti wraps the line:

complete after this: wo_ <---- cursor here, then trigger completion window
* This is a very very very long line that is longer than my olivetti mode keeps on one line and wraps to the second

That second line will shift to the left and it's very visually distracting lately, though I could easily ignore it at first.

Related:

company-mode/company-mode#272
zk-phi/sublimity#21

[rnkn]

Can't reproduce this sorry...

[dgutov]

Perhaps you have to use the same version of company to reproduce (most recent, from MELPA, right?).

[rnkn]

Then that would indicate a regression in company-mode.

[codygman]

I'll try to post exact versions including other package versions and a screencast gif with repro later.

[rnkn]

The other possibility is that someone broke the window display code in Emacs again, given that this happened three times in the last four major versions...

If you can provide a backtrace that would be more informative than versions. Maybe also have a look in your NEWS file for relevant changes

[dgutov]

I haven't tried olivetti yet, but the relevant change in Company might be the switch to using after-string instead of display overlay property for popup rendering. Which will be needed to show icons in the popup.

Perhaps it interferes with stuff this mode does?

[rnkn]

Nah, all this code does is essentially call set-window-margins on window-size-change-functions hook. There's no code here that could do what's being reported. I've reopened on the off-chance that there's a rather elaborate regression in Emacs master that might change the way margins are set, but probably not. If I had to guess I'd say that the company-mode change from display prop to after-string could be messing up Emacs's ability to accurately count the window width columns, but since I can't reproduce it (with current company-mode) it's just a guess.

[dgutov]

All right, thank you for trying.

Let's wait for @codygman with more details, then.