Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Bitcode AppstoreConnect Submit Issue (Xcode 16.0) #3638

Closed
yungblud opened this issue Sep 27, 2024 · 3 comments
Closed

[Bug]: Bitcode AppstoreConnect Submit Issue (Xcode 16.0) #3638

yungblud opened this issue Sep 27, 2024 · 3 comments
Labels
bug 🪲 Something isn't working

Comments

@yungblud
Copy link

yungblud commented Sep 27, 2024

Mapbox Implementation

Mapbox

Mapbox Version

10.1.31

React Native Version

0.75.3

Platform

iOS

@rnmapbox/maps version

10.1.31

Standalone component to reproduce

const Hello = () => null

Observed behavior and steps to reproduce

Similar issue with facebook/hermes#1525 (comment)

When I try to submit to appstore connect my build, Mapbox Bitcode issue has been raised. So I couldn't submit to appstoreconnect.

Expected behavior

Bitcode issue would be resolved with Xcode 16.0

Notes / preliminary analysis

Add this to |post_install| lane of Podfile

bitcode_strip_path = `xcrun --find bitcode_strip`.chop!
    def strip_bitcode_from_framework(bitcode_strip_path, framework_relative_path)
     framework_path = File.join(Dir.pwd, framework_relative_path)
     command = "#{bitcode_strip_path} #{framework_path} -r -o #{framework_path}"
     puts "Stripping bitcode: #{command}"
     system(command)
    end

    framework_paths = [
     "Pods/MapboxCommon/MapboxCommon.xcframework/ios-arm64/MapboxCommon.framework/MapboxCommon",
     "Pods/MapboxCommon/MapboxCommon.xcframework/ios-arm64_x86_64-maccatalyst/MapboxCommon.framework/MapboxCommon",
     "Pods/MapboxCommon/MapboxCommon.xcframework/ios-arm64_x86_64-simulator/MapboxCommon.framework/MapboxCommon",
     "Pods/MapboxCoreMaps/MapboxCoreMaps.xcframework/ios-arm64/MapboxCoreMaps.framework/MapboxCoreMaps",
     "Pods/MapboxCoreMaps/MapboxCoreMaps.xcframework/ios-arm64_x86_64-maccatalyst/MapboxCoreMaps.framework/MapboxCoreMaps",
     "Pods/MapboxCoreMaps/MapboxCoreMaps.xcframework/ios-arm64_x86_64-simulator/MapboxCoreMaps.framework/MapboxCoreMaps",
     "Pods/MapboxMobileEvents/MapboxMobileEvents.xcframework/ios-arm64_armv7/MapboxMobileEvents.framework/MapboxMobileEvents",
     "Pods/MapboxMobileEvents/MapboxMobileEvents.xcframework/ios-ios-arm64_i386_x86_64-simulator/MapboxMobileEvents.framework/MapboxMobileEvents",
     "Pods/MapboxMobileEvents/MapboxMobileEvents.xcframework/ios-arm64_x86_64-maccatalyst/MapboxMobileEvents.framework/MapboxMobileEvents"
    ]

    framework_paths.each do |framework_relative_path|
     strip_bitcode_from_framework(bitcode_strip_path, framework_relative_path)
    end

and pod install again.

The issue was gone.

Additional links and references

No response

@yungblud yungblud added the bug 🪲 Something isn't working label Sep 27, 2024
@github-actions github-actions bot reopened this Sep 27, 2024
@raptorian
Copy link

Using Xcode 15 works as a workaround

@jbcrestot
Copy link

look at #3635

@yungblud
Copy link
Author

yungblud commented Oct 2, 2024

Thanks, I think the issue was resolved by #3635 @jbcrestot
Closing this issue.

@yungblud yungblud closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants