Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/hll register does not perform steamid input validation #17

Open
robbmanes opened this issue Apr 14, 2023 · 2 comments
Open

/hll register does not perform steamid input validation #17

robbmanes opened this issue Apr 14, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@robbmanes
Copy link
Owner

Describe the bug
It is possible, as there is no input validation for the steam ID input, to break /hll register if an improper steam64id format is input. This input needs sanitization and checking.

Additional context
Discussed in further detail here: #14 (comment)

@robbmanes robbmanes added the bug Something isn't working label Apr 14, 2023
@robbmanes robbmanes self-assigned this Apr 14, 2023
@caranci
Copy link
Contributor

caranci commented Apr 14, 2023

Is there a compelling reason to allow ppl to register before their steamid64 has banked seeding time?
If the system only allowed registering against steamid64 ids that were already in the db table then I don't think further validation would be necessary.

@robbmanes
Copy link
Owner Author

Yes; theoretically, when users can grant VIP to each other (#19) having them pre-registered allows them to receive and check it via discord interface. In the grand scheme of things, having the discord<->steamid64 relationship for other uses is helpful IMO beyond just seeding re: future plans, so it was deliberate on my part, but in it's current rendition you're very correct that it serves no additional purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants