Lines that starts with a hyphen are interpretated as "Removed"

[Fresa]

At least that's what I think is causing the following issue.
Left is the output from Terraform Plan.
Right is the comment generated in the PR by the terraform-pr-commenter action.

Each line that starts with either the Terraform Remove hyphen sign or a yaml hyphen indicating a list item are highlighted in the comment as being removed.

I have blanked some values that contained "sensitive" information.

Download action repository 'robburger/terraform-pr-commenter@v1'
v1 is currently v1.3.0
0.14.9: Pulling from hashicorp/terraform

[robburger]

Thanks @Fresa - I'll try to think of a creative way to resolve this

[MPV]

In my experience, formatting the code block as terraform seems to give quite good highlighting for diffs nowadays, i.e:

# kubectl_manifest.argocd_bootstrap will be updated in-place
~ resource "kubectl_manifest" "argocd_bootstrap" {
  source:
    helm:
      parameters:
      - name: argocd.namespace
        value: argocd
-     - name: ingress_nginx.namespace
-       value: ingress-nginx
      valueFiles:
      - values.yaml
+     - values.prod.yaml
}

diff isn't too bad either:

# kubectl_manifest.argocd_bootstrap will be updated in-place
~ resource "kubectl_manifest" "argocd_bootstrap" {
  source:
    helm:
      parameters:
      - name: argocd.namespace
        value: argocd
-     - name: ingress_nginx.namespace
-       value: ingress-nginx
      valueFiles:
      - values.yaml
+     - values.prod.yaml
}

But hey, the kind of beautifully highlighted colors for "changes in resources" you're doing here is also really helpful. 🎉

Would be cool to solve it for all of GitHub though, and looking at https://github.com/github/linguist/blob/master/vendor/README.md it seems like this is the implementation that powers it: https://github.com/alexlouden/Terraform.tmLanguage/blob/master/Terraform.tmLanguage

I haven't figured out the details of how to do it in that file format, but I also raised an issue over there for discussing it: SublimeText/Terraform#51

[jcogilvie]

Also experiencing this issue. One of the context clues here is we can pick up <<-EOT as an indicator that what follows isn't strictly terraform output, so maybe treat lines a little differently until we hit EOT?

[jcogilvie]

If the terraform output is colorized, then the hyphens for "removals" are red and the ones for yaml lists are not. Maybe the commenter could use that fact instead of beginning by stripping the color?

Edit: yep, fixed in my fork. PR is up.