Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backporting the Tooltip #1

Open
robgha01 opened this issue Aug 5, 2018 · 1 comment · May be fixed by #3
Open

Backporting the Tooltip #1

robgha01 opened this issue Aug 5, 2018 · 1 comment · May be fixed by #3
Labels
help wanted Extra attention is needed

Comments

@robgha01
Copy link
Owner

robgha01 commented Aug 5, 2018

line 529 in TrufiGCD.lua
GameTooltip:SetSpellByID(self.spellID, false, false, true)

This is left to backport but im unsure how to fix it.

@robgha01 robgha01 added the help wanted Extra attention is needed label Aug 5, 2018
@BannZay BannZay linked a pull request Feb 21, 2020 that will close this issue
@BannZay
Copy link

BannZay commented Feb 21, 2020

I suppose the problem is in UNIT_SPELLCAST event. Arguments of it has been changed. But 3.3.5 contain spell name instead of spell id, what is not appropriate for GameTooltip:SetSpellByID

so if self.spellID contains spell name instead spell id it won't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants