chore: Closes https://github.com/robinhood/faust/issues/757 #773
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #757
I'd like to use this package in conjunction with other tools such as
black
that depend on a more modern version of theclick
library. As a shot in the dark, I am assuming that the upper bound pin onclick
was conservatively created before that version was released? This seems to be the case given the history of this line in the default requirements and the release of click 8.0.0 being two years later.In the spirit of that, I bumped to the next (yet to be released) major semver and ran the test suite on a local build using
Python 3.7.14
andclick==8.1.3
, and received the following results:Full disclosure, I did not vet this codebase heavily to see if there are any concerns with this major version bump, but in my own private projects that are pretty vanilla usage of
click
I have been able to make the upgrade pretty transparently. I am mostly relying on the test suite you have here to capture any breakages. I did a very quick scan of the release notes of click 8.0 and it mostly seems like they are making the switch due to dropping python 2 and 3.5 support. I will note that they do not say anything special in their upgrade document for version 8.0 or beyond: https://click.palletsprojects.com/en/8.1.x/upgrading/ which is likely a good sign. Someone with more intimate knowledge of this codebase may want to take a closer look at the extensive release notes just in case: https://click.palletsprojects.com/en/8.1.x/changes/#version-8-0-0