Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some joints go in HF if the max step size is decreased in Gazebo #522

Open
GiulioRomualdi opened this issue Nov 11, 2020 · 4 comments
Open

Comments

@GiulioRomualdi
Copy link
Member

If I decrease the max step size in Gazebo from 0.001 to 0.0001 torso and shoulder often go in hardware fault. As far as I understood the hardware fault is manually set if

// check measured torque for hw fault
for (size_t jnt_cnt = 0; jnt_cnt < m_jointPointers.size(); jnt_cnt++) {
if (m_controlMode[jnt_cnt]!=VOCAB_CM_HW_FAULT && fabs(m_torques[jnt_cnt])>m_maxTorques[jnt_cnt])
{
m_controlMode[jnt_cnt]=VOCAB_CM_HW_FAULT;
yError() << "An hardware fault occurred on joint "<< jnt_cnt << " torque too big! ( " << m_torques[jnt_cnt] << " )";
}
}

I completely understand that this is done to emulate the real robot model but it would be nice if this check can be easily disabled from the configuration file. It will help a lot while running simulations

cc @prashanthr05 @traversaro and @S-Dafarra

@GiulioRomualdi GiulioRomualdi changed the title Some joints goes in HF is the max step size is decrease in Gazebo Some joints goes in HF is the max step size is decreased in Gazebo Nov 11, 2020
@traversaro
Copy link
Member

I think you can increase the max_torques parameter in the conf file, see

if (kin_chain_bot.check("max_torques")) {
.

@traversaro
Copy link
Member

I am also open to increase the default, remove the default (i.e. requiring the parameter to be set in the .ini conf file) or do whatever it make sense to do.

@traversaro
Copy link
Member

If I decrease the max step size in Gazebo from 0.001 to 0.0001 torso and shoulder often go in hardware fault.

By the way, it would be interesting to understand why this happens, by decreasing the timestamp the numerical errors should decrease.

@pattacini pattacini changed the title Some joints goes in HF is the max step size is decreased in Gazebo Some joints go in HF if the max step size is decreased in Gazebo Nov 11, 2020
@GiulioRomualdi
Copy link
Member Author

Another possibility is to add a flag to disable the check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants