Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configurable "fail when no merge" #23

Open
ssorallen opened this issue Sep 23, 2024 · 1 comment
Open

Allow configurable "fail when no merge" #23

ssorallen opened this issue Sep 23, 2024 · 1 comment

Comments

@ssorallen
Copy link

ssorallen commented Sep 23, 2024

It would be great to allow configuring "fail when no merge was performed." The action always calls exit 0 when no merge is performed, but I would like to make that exit 1 to stop subsequent actions from running.

if git merge-base --is-ancestor $INPUT_STABLE_BRANCH $INPUT_DEVELOPMENT_BRANCH; then
echo "No merge is necessary"
exit 0
fi;

My use case, I am using this action to run a nightly build:

  1. this action runs to merge main into a named branch
  2. then another action is called to kick off an iOS build + deploy

I would like to not run step 2. if no merge was performed.

@traversaro
Copy link
Member

It make sense to me, put probably we want to have this under an option for back compatibility. Would you be interested in preparing a PR? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants