Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the usage of yarp::dev::IAnalogSensors #929

Open
2 of 10 tasks
Nicogene opened this issue Dec 28, 2023 · 8 comments
Open
2 of 10 tasks

Remove the usage of yarp::dev::IAnalogSensors #929

Nicogene opened this issue Dec 28, 2023 · 8 comments
Labels

Comments

@Nicogene
Copy link
Member

Nicogene commented Dec 28, 2023

I let things get out of hand and in the PR listed below I removed it also from other devices that had been already ported to the usage of the MultipleAnalogSensorsInterfaces

Looking at the usage of yarp::dev::IAnalogSensor interface in icub-main some devices still use it and they have not been ported to the MAS interfaces:

  • canBusAnalogSensor
  • canBusInertialMTB
  • canBusMotionControl
  • canBusSkin
  • embObjMulltiEnc
  • embObjPOS
  • embObjPSC
  • embObjSkin
  • skinWrapper
  • skinManager

We know that the skin pipeline has to be refactored, maybe some of them can be removed completely as we did for the embObjAnalogSensor

For the remaining we have to chat with @marcoaccame

Originally posted by @Nicogene in #919 (comment)

@Nicogene Nicogene self-assigned this Mar 14, 2024
@Nicogene
Copy link
Member Author

Nicogene commented Mar 29, 2024

Device Usage in robots-configurations Interfaces implemented Possible action
canBusAnalogSensor ☑️ view usage (CAN iCub) yarp::dev::IAnalogSensor Use canBusFtSensor for strain, create canBusMais similar to embObjMais, remove canBusAnalogSensor from robots-configuration and icub-main
canBusInertialMTB ☑️ view usage (CAN iCub) yarp::dev::IAnalogSensor Port it to MAS interfaces
canBusMotionControl ☑️ view usage (CAN iCub) Has a list of yarp::dev::IAnalogSensor ❓❓❓
canBusSkin ☑️ view usage (CAN iCub) yarp::dev::IAnalogSensor Refactor skin sw stack
embObjMulltiEnc view usage yarp::dev::IAnalogSensor Let's remove it from icub-main or we port it to MultiEncArray interface
embObjPOS ☑️ view usage (ergoCub) yarp::dev::IAnalogSensor ❓❓❓
embObjPSC ☑️ view usage (only CER) yarp::dev::IAnalogSensor ❓❓❓
embObjSkin ☑️ view usage (both ergoCub and iCub) yarp::dev::IAnalogSensor Refactor skin sw stack

skinWrapper and skinManager are executables that until we do not refactor the skin sw stack will rely on IAnalogSensor

I tried to write down the current situation with some possible action points for what I know, @marcoaccame @traversaro @pattacini please feel free to contribute to this table

@Nicogene Nicogene changed the title Remove the usage of yarp::dev::IAnalogSensors Remove the usage of yarp::dev::IAnalogSensors – Stint 1 Mar 29, 2024
@traversaro
Copy link
Member

fyi @valegagge , as apparently she was the original author of embObjMultiEnc: 7578d28 .

@valegagge
Copy link
Member

Hi guys,
I report here some information related to the embObjMultiEnc.
In r1SN001 there is an encoder called spichainof3 at joint.
As the name says, the joint position is calculated by a combination of 3 spi encoder using the matrix defined in the mechanical file.
So the joint position in this robot is provided as usual, but we needed a way to publish the value of each single joint, especially in the first stages of development and testing on this architecture.
From this need, we developed the embObjMultiEnc.

I also looked around in the fw. the code that can publish such values still exists, but I didn't understand if they are broadcasted toward YRI.(I guess no)

Said that, I suppose that now there are very occasions where we need to check the raw value of the spichainof3 encoder. they are only on R1 robot.

In my opinion, we can remove the device, but we need to take into account that maybe we need to develop it. (it is a slim chance.)

@Nicogene
Copy link
Member Author

/remind 6th may plan for action points

Copy link

octo-reminder bot commented Apr 16, 2024

Reminder
Monday, May 6, 2024 10:00 AM (GMT+02:00)

plan for action points

Copy link

octo-reminder bot commented May 6, 2024

🔔 @Nicogene

plan for action points

@Nicogene
Copy link
Member Author

Nicogene commented Jun 27, 2024

Action points

@Nicogene Nicogene added the Epic label Jun 27, 2024
@Nicogene
Copy link
Member Author

I converted this to an Epic, you can link your activities to this.

cc @pattacini @valegagge @marcoaccame @MSECode @simeonedussoni @mfussi66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants