Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent different users from using the same name #42

Closed
PizieDust opened this issue Sep 11, 2024 · 3 comments · Fixed by #44
Closed

Prevent different users from using the same name #42

PizieDust opened this issue Sep 11, 2024 · 3 comments · Fixed by #44
Assignees
Labels
bug Something isn't working security Something potentially related to security

Comments

@PizieDust
Copy link
Collaborator

Currently multiple accounts can have the exact same name. We require the email to be unique but not the name.
This can be problematic given that the domain used by albatross is the name of the account.

@PizieDust PizieDust added the bug Something isn't working label Sep 11, 2024
@hannesm hannesm added the security Something potentially related to security label Sep 11, 2024
@PizieDust
Copy link
Collaborator Author

What about using the users uuid for domain purposes? This can be a quick fix in this case.
But I assume the other frontends (grafana), may not like the uuid values (if it's displayed somewhere in the UI?)

@hannesm
Copy link
Contributor

hannesm commented Sep 11, 2024

For now, esp. since we've a running albatross with existing setup (and there's no UUID prefix for the unikernels), and the question about where such a mapping (user name and uuid) should be persisted (if needed) -- see robur-coop/albatross#173 -- I'd prefer to check that the user name is unique.

@PizieDust
Copy link
Collaborator Author

Thank you for the additional context on the albatross issue. I totally agree it's a bit more complex to decide. I think we can easily just check the names and prevent duplicate ones for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working security Something potentially related to security
Development

Successfully merging a pull request may close this issue.

2 participants