Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Cameras with high Opening Angles #77

Open
maltewi opened this issue Mar 8, 2018 · 1 comment
Open

Support for Cameras with high Opening Angles #77

maltewi opened this issue Mar 8, 2018 · 1 comment

Comments

@maltewi
Copy link
Contributor

maltewi commented Mar 8, 2018

Currently Mars seems not to support cameras with high opening angles (>pi) . It should be investigated why this is the case and if there's a possibility to support them.

Here's what written on the terminal when including a camera with high opening angle:

mars_app: /build/rock-master-18.01-simulation-mars-graphics-0.20171213/src/GraphicsCamera.cpp:371: virtual void mars::graphics::GraphicsCamera::setFrustumFromRad(double, double, double, double): Assertion `(horizontalOpeningAngle < M_PI) && (horizontalOpeningAngle > 0)' failed.

I think we exit with an error! Signal: 6
@malter
Copy link
Member

malter commented Mar 9, 2018

I don't see a reason for that limitation. You can comment the assert calls or build as release to ignore them. The camera should be rendered correctly. If you can confirm this, I will remove the restriction with the next update of the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants