-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make registry of used base image explicit #348
Comments
Interesting. I'm actually not familiar with that syntax, though I see the logic, it's not mentioned in Dockerfile best practices (https://docs.docker.com/develop/develop-images/dockerfile_best-practices/) or documented in the Dockerfile reference (https://docs.docker.com/engine/reference/builder/#from). I'm just wary of adopting a syntax that might be incompatible with other tools or confuse users. There are also some side-effects to this behavior that might be undesirable. For instance, we often test the stack by building the entire stack locally. If I build a local Does podman not have the ability to just set |
p.s. how about adding pps. podman does look very cool, will be interested to check out what you're doing with |
As @cboettig mentioned I also get error while running Just to let you know: A similar issue is reported, if I try to recreate the build process for the |
I've been playing around with
podman
and Rocker images a bit, see README in https://github.com/nuest/rodmanAlthough is a known issue with RStudio in containers started with podman, see #202, running the R prompt was no problem at all. Building the image required a small fix: prepending the registry name in the
FROM
instruction, which is added by default for the Docker CLI:For example, the
r-ver:3.6.0
Dockerfile would start withThe
rstudio:3.6.0
file would start withWhat do you think about adding the registry and library explicitly to all Dockerfiles?
Advantages I see:
The text was updated successfully, but these errors were encountered: