Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing user-created wallet password on wallet init #248

Open
superphiz opened this issue Sep 23, 2022 · 0 comments · May be fixed by #322
Open

Consider removing user-created wallet password on wallet init #248

superphiz opened this issue Sep 23, 2022 · 0 comments · May be fixed by #322

Comments

@superphiz
Copy link

When the user runs rocketpool wallet init they are prompted to generate a wallet password that is used by the smartnode, but the user never needs to use this password (to my knowledge). Since the user backs up the wallet via a seed phrase, it seems to make sense for the system to generate a random password rather than asking the user to generate a password they'll never need.
@angaz angaz linked a pull request Mar 12, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Give option to generate wallet password angaz/smartnode
1 participant
@superphiz