Skip to content
This repository has been archived by the owner on Mar 22, 2019. It is now read-only.

#15 Includes a Hardcoded Path #16

Open
mathewhall opened this issue Jul 24, 2017 · 5 comments
Open

#15 Includes a Hardcoded Path #16

mathewhall opened this issue Jul 24, 2017 · 5 comments

Comments

@mathewhall
Copy link

Merge of #15 includes a hardcoded path: +#include "/root/pfe2/headers/functions/pfe_v2.hpp" in external/bolt/include/bolt/amp/detail/reduce.inl. Also, on a related note, the installation instructions don't include any mention of this pfe2 library.

@wsttiger
Copy link
Contributor

The bolt_pfe2 branch is only a temporary branch and was never meant to be used. I plan to delete it. Thanks.

@mathewhall
Copy link
Author

This isn't on the bolt_pfe2 branch though. This is present on the default branch (hip). It came from the bolt_pfe2 branch but it was merged into the default.

@mathewhall
Copy link
Author

It's not a huge issue, I just synced to HEAD^ to fix it, but I do want to point out that this issue causes the install instructions to not work.

@victor-felicitas
Copy link

Hi! Any ways how to properly delete it? I cant install Cutorch due to pf2 fatal error. It seems pfe2 is in reduce.inl and transform.inl...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants