Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"PlayDuration" is only supported when used with TimeGrid component. #59

Open
Manvendra-Jadon opened this issue Apr 9, 2021 · 7 comments

Comments

@Manvendra-Jadon
Copy link

Manvendra-Jadon commented Apr 9, 2021

Recently i integrated TimeGrid component in my project for EPG guide, but now i am getting this error in static analysis:
"PlayDuration" is only supported when used with TimeGrid component. All other uses have been deprecated.

Reference: https://developer.roku.com/docs/references/scenegraph/list-and-grid-nodes/timegrid.md
https://github.com/rokudev/SceneGraphDeveloperExtensions/tree/master/samples/TimeGridView
I have used this on my end to implement EPG.

I think, this is something on Roku's end. As this is a new implementation, don't think it can be deprecated this quickly. Getting this error even when we have TimeGrid component used in channel.
FireShot Capture 015 - Roku - developer roku com

@RokuChris
Copy link
Contributor

Static analysis isn't part of SGDEX. This would typically be something to followup with your partner manager. In this case I agree that the tool is being overly aggressive and the team that works on it is investigating.

@Manvendra-Jadon
Copy link
Author

@RokuChris Thanks.

@neilsb
Copy link

neilsb commented Apr 14, 2021

We also hit this issue.

We have a Task that loads schedule information from the server and returns an array of ContentNode objects which we assign to the TimeGrid. The fact that we set PlayDuration in the task is causing the static analysis to fail.

As a workaround we can set a different property in our loading task (e.g. ProgramDuration), and then in the TimeGrid screen we can loop through all the results of the task setting PlayDuration = ProgramDuration.

Having the static analysis bring this up as a warning seemed unnecessary, but now having it as error seems like it's the wrong thing to do.

@Manvendra-Jadon
Copy link
Author

@neilsb I tried setting different property, but TimeGrid doesn't create slots after that. So don't think workaround can work here. Did you do it successfully?

@neilsb
Copy link

neilsb commented Apr 14, 2021

Sorry - I was incorrect. Trying to assign PlayDuration = ProgramDuration in the screen containing the TimeGrid component still fails static analysis.

As far as I can see, as it stands right now there is no to set PlayDuration for a ContentNode and therefor now way to have a working TimeGrid pass Static Analysis.

@unwiredben
Copy link

http://devtools.web.roku.com/#static-channel-analysis-tool has been updated to 7.9.3 with a fix for this.

@Manvendra-Jadon
Copy link
Author

@unwiredben Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants