Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider an integration with exception notifier #711

Closed
Startouf opened this issue Apr 4, 2018 · 3 comments
Closed

Consider an integration with exception notifier #711

Startouf opened this issue Apr 4, 2018 · 3 comments
Labels

Comments

@Startouf
Copy link

Startouf commented Apr 4, 2018

The exception notifier gem allows to wrap several notifiers (email, slack, etc.). It would be nice to have a Rollbar notifier plugin for this gem

I know this can feel like a duplicate tool since Rollbar offers to some extent the same functionalities via the web interface, exception_notifier is agnostic and but you'd be able to very easily integrate with existing systems (almost 2k likes on the exception notifier gem). Also it would make migrating much easier.

Currently if I want to integrate Rollbar, I'd have to add code everywhere, whereas if there was an exception_notifier extension I could get everything for free.

Mirror issue smartinez87/exception_notification#413

@Startouf
Copy link
Author

Startouf commented Apr 5, 2018

I'm in the process of writing a custom adapter but it seems all rollbar requests are sent in duplicates. If I understand well, there is a railties that already adds the Rollbar as some kind of middleware.
Until supported, I'll need to monkeypatch to disable this integration since I want to have control of Rollbar notifications via Exception notifier

EDIT: I'm struggling to find what I need the rollbar code, if you could hint me to where/how I could disable the default reporting after an exception, and how I can reuse the existing code to automatically populate Rollbar with useful info from a request, that would be nice.

I am working on this gist

@rivkahstandig3636 rivkahstandig3636 added this to the Spikes milestone Apr 5, 2018
@rivkahstandig3636
Copy link
Contributor

We will take a look into this, sorry for the delay!

@jessewgibbs
Copy link
Contributor

Marking this as wontfix as we're not going to be able to consider this any time soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants