Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Renaming games that contains accents breaks urls, and thus breaks download and play for that game. #1212

Open
outerwinnie opened this issue Sep 24, 2024 · 2 comments · Fixed by #1224
Open

[Bug] Renaming games that contains accents breaks urls, and thus breaks download and play for that game. #1212

outerwinnie opened this issue Sep 24, 2024 · 2 comments · Fixed by #1224
Assignees
@adamantike
Labels
bug Something isn't working

Comments

@outerwinnie
Copy link

RomM version
3.5.1

Describe the bug
When using the renaming option in RomM, if the game has an accent the filename is going to have it too and that breaks urls. (and thus download and play options for that game)

To Reproduce
Steps to reproduce the behavior:

  1. Pick any Pokémon game for example
  2. Use the renaming function of RomM with the rom
  3. Try to download it, or play it
  4. See error

Expected behavior
RomM shouldn't add accents to filenames.
@outerwinnie outerwinnie added the bug Something isn't working label Sep 24, 2024
@adamantike
Copy link
Collaborator

I don't think the expected behavior here is to not add accents to the files. Ideally, any character supported by the filesystem should not be removed from filenames, to not enforce the user to a reduced charset.

Instead, this sounds more like failing to correctly quote some of the URLs, to escape any special characters.

@adamantike adamantike self-assigned this Oct 6, 2024
adamantike added a commit that referenced this issue Oct 6, 2024
@adamantike
fix: Escape URLs when files are served by nginx
60ff832 
When serving files using the `X-Accel-Redirect` header in nginx, the
header values must be URL-encoded. Otherwise, nginx will not be able
to serve the files if they contain special characters.

This commit adds a new `FileRedirectResponse` class to the `utils.nginx`
module, to simplify the creation of responses that serve files using the
`X-Accel-Redirect` header.

Fixes #1212, #1223.
@adamantike adamantike mentioned this issue Oct 6, 2024
Merged
@adamantike adamantike linked a pull request Oct 6, 2024 that will close this issue
fix: Escape URLs when files are served by nginx #1224
Merged
@adamantike
Copy link
Collaborator

A fix for this has been merged, and will be available in the next release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamantike adamantike

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Escape URLs when files are served by nginx rommapp/romm
2 participants
@adamantike @outerwinnie