Prep step for cyclomatic complexity failed.

[jasonserviss]

Hello,

Wanted to give this package a test drive today but hit some errors directly. Output below:

path <- find.package("methods") path

[1] "/Library/Frameworks/R.framework/Resources/library/methods"

g <- goodpractice::gp(path)

Preparing: covr
Preparing: cyclocomp
Preparing: description
Preparing: lintr
Preparing: namespace
Preparing: rcmdcheck
Warning messages:
1: In structure(c(coverage, res), class = "coverage", package = pkg, :
Calling 'structure(NULL, *)' is deprecated, as NULL cannot have attributes.
Consider 'structure(list(), *)' instead.
2: In MYPREPS[[prep]](state, quiet = quiet) :
Prep step for cyclomatic complexity failed.
3: In MYPREPS[[prep]](state, quiet = quiet) :
Prep step for rcmdcheck failed.

path <- find.package("tibble") path

[1] "/Library/Frameworks/R.framework/Versions/3.5/Resources/library/tibble"

g <- goodpractice::gp(path)

Preparing: covr
Preparing: cyclocomp
Preparing: description
Preparing: lintr
Preparing: namespace
Preparing: rcmdcheck
Warning messages:
1: In MYPREPS[[prep]](state, quiet = quiet) :
Prep step for cyclomatic complexity failed.
2: In MYPREPS[[prep]](state, quiet = quiet) :
Prep step for rcmdcheck failed.

sessionInfo()

R version 3.5.0 (2018-04-23)
Platform: x86_64-apple-darwin15.6.0 (64-bit)
Running under: macOS High Sierra 10.13.4

Matrix products: default
BLAS: /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBLAS.dylib
LAPACK: /Library/Frameworks/R.framework/Versions/3.5/Resources/lib/libRlapack.dylib

locale:
[1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8

attached base packages:
[1] stats graphics grDevices utils datasets methods base

loaded via a namespace (and not attached):
[1] igraph_1.2.1 Rcpp_0.12.17 rex_1.1.2 xmlparsedata_1.0.1
[5] rstudioapi_0.7 knitr_1.20 xml2_1.2.0 magrittr_1.5
[9] covr_3.1.0 rcmdcheck_1.2.1 R6_2.2.2 stringr_1.3.1
[13] httr_1.3.1 tools_3.5.0 goodpractice_1.0.2.9000 cyclocomp_1.1.0
[17] lintr_1.0.2 withr_2.1.2 remotes_1.1.1 yaml_2.1.19
[21] lazyeval_0.2.1 assertthat_0.2.0 rprojroot_1.3-2 digest_0.6.15
[25] crayon_1.3.4 processx_3.1.0 whoami_1.1.2 callr_2.0.4
[29] clisymbols_1.2.0 praise_1.0.0 stringi_1.2.2 compiler_3.5.0
[33] desc_1.2.0 backports_1.1.2 jsonlite_1.5 pkgconfig_2.0.1 `

[gaborcsardi]

path should point to the source tree of a package, not an installed package. The installed package (usually) does not have the complete source code, so we cannot do code analysis on installed packages.

[gaborcsardi]

That said, the error message could be better...

[jasonserviss]

Ahh, ok. That makes sense. I should have looked a bit closer at the example. Thanks for the quick response!

[annakrystalli]

Hi! I'm also having this problem but with the path pointing to the source code.

The following code should reproduce the problem:

tmpdir <- file.path(tempfile(), "BaseSet")
dir.create(tmpdir, recursive = T)
git2r::clone("https://github.com/annakrystalli/BaseSet", local_path = tmpdir)
goodpractice::gp(tmpdir)

which outputs the following:

Preparing: covr
Preparing: cyclocomp
Prep step for cyclomatic complexity failed.Preparing: description
Preparing: lintr
Preparing: namespace
Preparing: rcmdcheck
Prep step for rcmdcheck failed.── GP BaseSet 

Here's my session info:

devtools::session_info()
#> ─ Session info ───────────────────────────────────────────────────────────────
#>  setting  value                       
#>  version  R version 3.6.0 (2019-04-26)
#>  os       macOS Mojave 10.14.3        
#>  system   x86_64, darwin15.6.0        
#>  ui       X11                         
#>  language (EN)                        
#>  collate  en_GB.UTF-8                 
#>  ctype    en_GB.UTF-8                 
#>  tz       America/Los_Angeles         
#>  date     2020-01-28                  
#> 
#> ─ Packages ───────────────────────────────────────────────────────────────────
#>  package     * version date       lib source        
#>  assertthat    0.2.1   2019-03-21 [1] CRAN (R 3.6.0)
#>  backports     1.1.5   2019-10-02 [1] CRAN (R 3.6.0)
#>  callr         3.4.0   2019-12-09 [1] CRAN (R 3.6.0)
#>  cli           2.0.1   2020-01-08 [1] CRAN (R 3.6.0)
#>  crayon        1.3.4   2017-09-16 [1] CRAN (R 3.6.0)
#>  desc          1.2.0   2018-05-01 [1] CRAN (R 3.6.0)
#>  devtools      2.2.1   2019-09-24 [1] CRAN (R 3.6.0)
#>  digest        0.6.23  2019-11-23 [1] CRAN (R 3.6.0)
#>  ellipsis      0.3.0   2019-09-20 [1] CRAN (R 3.6.0)
#>  evaluate      0.14    2019-05-28 [1] CRAN (R 3.6.0)
#>  fansi         0.4.1   2020-01-08 [1] CRAN (R 3.6.0)
#>  fs            1.3.1   2019-05-06 [1] CRAN (R 3.6.0)
#>  glue          1.3.1   2019-03-12 [1] CRAN (R 3.6.0)
#>  highr         0.8     2019-03-20 [1] CRAN (R 3.6.0)
#>  htmltools     0.4.0   2019-10-04 [1] CRAN (R 3.6.0)
#>  knitr         1.27    2020-01-16 [1] CRAN (R 3.6.0)
#>  magrittr      1.5     2014-11-22 [1] CRAN (R 3.6.0)
#>  memoise       1.1.0   2017-04-21 [1] CRAN (R 3.6.0)
#>  pkgbuild      1.0.6   2019-10-09 [1] CRAN (R 3.6.0)
#>  pkgload       1.0.2   2018-10-29 [1] CRAN (R 3.6.0)
#>  prettyunits   1.1.0   2020-01-09 [1] CRAN (R 3.6.0)
#>  processx      3.4.1   2019-07-18 [1] CRAN (R 3.6.0)
#>  ps            1.3.0   2018-12-21 [1] CRAN (R 3.6.0)
#>  R6            2.4.1   2019-11-12 [1] CRAN (R 3.6.0)
#>  Rcpp          1.0.3   2019-11-08 [1] CRAN (R 3.6.0)
#>  remotes       2.1.0   2019-06-24 [1] CRAN (R 3.6.0)
#>  rlang         0.4.2   2019-11-23 [1] CRAN (R 3.6.0)
#>  rmarkdown     2.1     2020-01-20 [1] CRAN (R 3.6.0)
#>  rprojroot     1.3-2   2018-01-03 [1] CRAN (R 3.6.0)
#>  sessioninfo   1.1.1   2018-11-05 [1] CRAN (R 3.6.0)
#>  stringi       1.4.5   2020-01-11 [1] CRAN (R 3.6.0)
#>  stringr       1.4.0   2019-02-10 [1] CRAN (R 3.6.0)
#>  testthat      2.3.1   2019-12-01 [1] CRAN (R 3.6.0)
#>  usethis       1.5.1   2019-07-04 [1] CRAN (R 3.6.0)
#>  withr         2.1.2   2018-03-15 [1] CRAN (R 3.6.0)
#>  xfun          0.12    2020-01-13 [1] CRAN (R 3.6.0)
#>  yaml          2.2.0   2018-07-25 [1] CRAN (R 3.6.0)
#> 
#> [1] /Library/Frameworks/R.framework/Versions/3.6/Resources/library

^{Created on 2020-01-28 by the reprex package (v0.3.0)}

Any ideas? Am I missing something?

Thanks!

[annakrystalli]

Actually, I figured out that the problem was missing suggested dependencies. All worked fine after they were installed so the comment is perhaps more relevant to #129