Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when no Authors@R? #69

Closed
maelle opened this issue Apr 9, 2018 · 4 comments
Closed

Error when no Authors@R? #69

maelle opened this issue Apr 9, 2018 · 4 comments
Milestone

Comments

@maelle
Copy link
Member

maelle commented Apr 9, 2018

am doing this in dev at least 🙈

@maelle
Copy link
Member Author

maelle commented Apr 9, 2018

But maybe that's just my being lazy as @jeroen made me realize.

Your call @cboettig , I'll gladly add some of the parsing code back 😀

@maelle
Copy link
Member Author

maelle commented Apr 9, 2018

I now think the worst case should be a warning.

@cboettig
Copy link
Member

cboettig commented Apr 9, 2018

yeah, I think in general codemetar should as agnostically as possible write any metadata it finds from DESCRIPTION into a codemeta.json file.

I'd suggest using a message rather than a warning to alert the user to any missing fields, unless that missing field meant some other aspect of the codemetar routine would risk having errors/mistakes (e.g. if we are using the URL field as the base url in other elements, a warning should say so).

@maelle
Copy link
Member Author

maelle commented Apr 9, 2018

cf #76 :-)

@maelle maelle closed this as completed Apr 9, 2018
@maelle maelle added this to the 0.1.6 release milestone Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants