Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check scope of GITHUB_PAT #265

Open
krlmlr opened this issue May 29, 2020 · 4 comments
Open

Check scope of GITHUB_PAT #265

krlmlr opened this issue May 29, 2020 · 4 comments

Comments

@krlmlr
Copy link
Collaborator

krlmlr commented May 29, 2020

before performing actions.

By default I'm using a very poorly scoped PAT if any, only adding a powerful one if needed. Protection against shooting myself in the foot.

@pat-s
Copy link
Member

pat-s commented May 29, 2020

The one used currently is the one provided by GitHub during every GHA build.
It only aims to prevent {remotes} rate limit issues.

If there is a more powerful one needed, the respective secret name would need to be updated.

@pat-s
Copy link
Member

pat-s commented Jun 24, 2020

What would be a possible action by {tic} depending on path's scope?

@pat-s
Copy link
Member

pat-s commented Aug 27, 2020

Unless there are some special tasks being executed (like workflow updates) the default PAT inserted by GitHub does the job.

I don't think we need to specifically check a PAT's scope, at least not now. People who need special scopes usually know that they need to add one to the build and reference it accordingly.

@pat-s pat-s closed this as completed Aug 27, 2020
@krlmlr
Copy link
Collaborator Author

krlmlr commented Aug 27, 2020

This is about the token used in use_tic() . Agree we don't need special handling inside GHA.

@krlmlr krlmlr reopened this Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants