ROS2 Branch: SoundClient blocking mode does not work

[antbono]

Hello Everyone!

I'm using the ros2 branch. I tried to execute the simple node in scripts/play.py and I noticed that the blocking mode is not working actually: the program ends before the sound file is completely played.

Has anyone had the same issue?

Thanks

[knorth55]

could you check if the client topic stops at this line?

audio_common/sound_play/sound_play/libsoundplay.py

Line 377 in e4b7087

rclpy.spin_until_future_complete(self.node, future)

[antbono]

Hi @knorth55!

I checked out, and I can confirm that the client stops at the line you highlighted.

Moreover when I use the non blocking mode I get this kind of error

[ERROR] [1695310239.114727197] [sound_play]: callback: sound_play.msg.SoundRequest(sound=-2, command=1, volume=1.0, arg='/tmp/output.ogg', arg2='')

but I can actually listen to the audio file.

[knorth55]

so you mean that this issues is solved?

[antbono]

No, the issue is not solved.
Even if sound_play_node.py send a message of action completed

audio_common/sound_play/scripts/soundplay_node.py

Line 560 in e4b7087

self.get_logger().info('sound_play action: Succeeded')

when I use SoundClient in my node, it never completes the command

audio_common/sound_play/sound_play/libsoundplay.py

Line 377 in e4b7087

rclpy.spin_until_future_complete(self.node, future)

and thus my node waits the reply forever.