Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pure CMake Build #17

Open
ben-greenberg opened this issue Jul 24, 2019 · 3 comments
Open

Pure CMake Build #17

ben-greenberg opened this issue Jul 24, 2019 · 3 comments

Comments

@ben-greenberg
Copy link

I have converted this package to use pure CMake to enable cross compatibility between ROS1 and ROS2. The core functionality works but the tests have not yet been implemented. Against which branch should I open a PR to share this work with the community?

@keshavchintamani
Copy link

keshavchintamani commented Nov 26, 2019

@ben-greenberg any updates on this issue. I'd be happy to contribute to this initiative. Would be ideal if we could create a ros2-devel branch here

@schornakj
Copy link

schornakj commented Oct 19, 2020

In my opinion the cleanest approach would be to make the main branch of this repo ROS-independent, since there isn't anything here that depends on ROS-specific functionality. There are a handful of fixes needed to build on Focal but I think they're already implemented in this branch (edit: which, upon further investigation, has already been merged into kinetic-devel).

One option would be to merge the changes that @ben-greenberg and I have implemented into kinetic-devel and not worry about having feature-specific branches. Or, a maintainer could create a new devel branch and the changes could be merged in there.

Who is maintaining this package currently? Does the strategy I've described sound OK to you?

@Rayman
Copy link

Rayman commented Nov 26, 2020

This would be nice, because it would allow for a very smooth migration to ROS2. A plain cmake package could work in both distros. For an example, see this abb driver where they have taken that approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants