-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pure CMake Build #17
Comments
@ben-greenberg any updates on this issue. I'd be happy to contribute to this initiative. Would be ideal if we could create a ros2-devel branch here |
In my opinion the cleanest approach would be to make the main branch of this repo ROS-independent, since there isn't anything here that depends on ROS-specific functionality. There are a handful of fixes needed to build on Focal but I think they're already implemented in this branch (edit: which, upon further investigation, has already been merged into One option would be to merge the changes that @ben-greenberg and I have implemented into Who is maintaining this package currently? Does the strategy I've described sound OK to you? |
This would be nice, because it would allow for a very smooth migration to ROS2. A plain cmake package could work in both distros. For an example, see this abb driver where they have taken that approach. |
I have converted this package to use pure CMake to enable cross compatibility between ROS1 and ROS2. The core functionality works but the tests have not yet been implemented. Against which branch should I open a PR to share this work with the community?
The text was updated successfully, but these errors were encountered: