-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition robot models to main repository #46
Comments
I would like to see all the *_experimental repos be merged with the main repo. They should still be clearly identified This would allow us to:
|
Just a data point on the 'visibility' of (support) pkgs in experimental repositories: the pkgs in I've recently submitted the |
@Jmeyer1292 wrote:
Should they first be updated to follow the ABB naming conventions? |
I agree with updating them to the latest naming convention prior to transitioning them to the main repository. |
Well I look forward to reviewing the pull requests from the maintainers of this package! |
I think the visibility concerns for the packages in this repository have been addressed now that the ROS doc indexer has rebuilt everything today. See wiki/abb_experimental. |
Back to @Jmeyer1292's original comment, do we have requirements that need to be satisfied to move these robots to the main repo? Are there any measurable metrics? |
No, not at this time.
yes. The point of having things in an experimental repository is that it allows the maintainers to make any potentially breaking changes without prior notice, that it allows for some soak time for new packages and to make them available to users to expose them to use-cases that are not necessarily those of the original author / maintainer. After a certain amount of time packages stabilise and could be moved to the main repositories. At that point, the regular rules start to apply: semantic versioning, backwards-compatibility guarantees (tick-tock, etc) and all the rest. Tbh I don't quite get what the problem is with this scheme. If it's lower visiblity then I believe we've addressed that with the creation of wiki/abb_experimental. If you take a look at the repository stats you'll see that that resulted in quite some traffic. My experience with If it's the fact that experimental repositories are not released and have to be build from sources: I would say that anyone doing anything serious with ROS will have a workspace and runs Catkin once in a while anyway. With a proper The fact that #45, #53, #54, #56, #60, #63, #64, #65 and #67 were submitted -- and just for the few support pkgs that were contributed in the past few months -- I think shows that letting things sit here for some time is not such a bad thing. Perhaps we could quantify what "a certain amount of time" is. That could take away some of the apparent 'arbitrary-ness' of when things do get migrated. |
The
irb120
,irb120t
, andirb4400
have all been in this repository for > 2 years and should be transitioned to the main abb repo.The text was updated successfully, but these errors were encountered: