Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add Windows builds #3

Open
gavanderhoorn opened this issue Dec 21, 2020 · 7 comments
Open

ci: add Windows builds #3

gavanderhoorn opened this issue Dec 21, 2020 · 7 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@gavanderhoorn
Copy link
Member

We should add Windows builds to CI. Here, and in ros-industrial/abb_egm_rws_managers and ros-industrial/abb_robot_driver_interfaces.

@gavanderhoorn gavanderhoorn added enhancement New feature or request help wanted Extra attention is needed labels Dec 21, 2020
@gavanderhoorn
Copy link
Member Author

Can probably re-use (parts of) the builds in abb_libegm and abb_librws.

@traversaro
Copy link

traversaro commented Mar 12, 2021

Can probably re-use (parts of) the builds in abb_libegm and abb_librws.

Unfortunately those one use vcpkg for their dependencies, and as far as I know there is no easy to use/fast way to build ROS on top of vcpkg provided dependencies.

The two main options that come to my mind are:

Related to the second point, I plan to eventually package abb_libegm and abb_librws in conda-forge, that should make the CI setup easier.

@gavanderhoorn
Copy link
Member Author

Personally I don't develop on Windows, which is also why this is labelled help-wanted -- which is from my perspective, as I created the issue.

The two main options that come to my mind are

Again, personally, I don't really have a preference, as long as whatever we end up implementing gives a good indication of whether or not Windows builds are successful and those builds can be used for CI purposes (ie: detecting regressions, etc).

btw @traversaro: the two links to the build-windows.yml files seem to be the same. Were those supposed to link to something different?

@traversaro
Copy link

btw @traversaro: the two links to the build-windows.yml files seem to be the same. Were those supposed to link to something different?

Yes, sorry for that, I fixed the second link now.

@traversaro
Copy link

Personally I don't develop on Windows, which is also why this is labelled help-wanted -- which is from my perspective, as I created the issue.

The two main options that come to my mind are

Again, personally, I don't really have a preference, as long as whatever we end up implementing gives a good indication of whether or not Windows builds are successful and those builds can be used for CI purposes (ie: detecting regressions, etc).

Same here, as I don't use ROS at least for ABB-related stuff. I just wanted to drop a few pointers as I saw the abb_libegm/abb_librws CI setup mentioned, as I know that Windows CI and packaging usually scares a bit contributors, so having a few pointers could be helpful.

@gavanderhoorn
Copy link
Member Author

so having a few pointers could be helpful.

certainly. Grazie mille.

@ooeygui
Copy link

ooeygui commented Jun 21, 2021

Azure Edge Robotics has documentation for CI using Github actions for Windows:
https://ms-iot.github.io/ROSOnWindows/GettingStarted/GithubSetupCI.html

(Once we complete the MoveIt2 work, I'll check back on this thread)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Development

No branches or pull requests

3 participants