Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Unit Tests #139

Open
4 tasks
marip8 opened this issue Jun 22, 2021 · 0 comments
Open
4 tasks

Improve Unit Tests #139

marip8 opened this issue Jun 22, 2021 · 0 comments

Comments

@marip8
Copy link
Member

marip8 commented Jun 22, 2021

Problems

Solutions

  • Revise unit tests to use test fixtures to reduce code duplication
  • Add meaningful expectations to the results of the tool path generation (e.g. number of strokes, number of points per stroke, normal direction
  • Fix issues with surface walk and eigen value edge planners
  • Transform test meshes by non-identity transformation to ensure results are correct and not just coincidentally correct (see Fix plane slice planner #136)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant